openapi-generator: [BUG][typescript-angular] All properties generated with "?:" even when they are not optional

@VincentVanclef AFAIK you need to fix your swagger definitions, I didn’t find any other way to force the properties to be non-optional

I ended up adding this scema:

    {
        public void Apply(OpenApiSchema schema, SchemaFilterContext context)
        {
            if (schema.Properties == null)
            {
                return;
            }

            var notNullableProperties = schema
                .Properties
                .Where(x => !x.Value.Nullable && !schema.Required.Contains(x.Key))
                .ToList();

            foreach (var property in notNullableProperties)
            {
                schema.Required.Add(property.Key);
            }
        }
    }`


services.AddSwaggerGen(c =>
            {
                c.DescribeAllParametersInCamelCase();

                c.SupportNonNullableReferenceTypes();
                c.SchemaFilter<RequiredNotNullableSchemaFilter>();```


would this be how you did it as well?

For many of us “nullable” mostly equals to “optional”, because it’s really exotic scenario when we want to get parameter explicitly set to “null” value. On the other hand, even more exotic scenario is non-nullable optional properties. Why would you expect to get non-nullable property set?

Maybe there can be a generator option something like ''treatNonNullablePropertiesAsOptional"? which will generate non-nullable non-optional fields for non-nullable properties and nullable-and-optional fields for nullable properties?

@agilob I don’t know how the tests look, but they are wrong. By definition nullable is false by default(https://swagger.io/specification/)! Yet not setting nullable at all treats nullable as true.

There’s a difference between a field being nullable (controlled by the “nullable” property in the OpenAPI spec, which pr default is false) and a field being optional (controlled inversely by the “required” property in the OpenAPI spec, which pr default is also false).

Nullable is represented like this in TypeScript:

export interface Interface1 {
   nullableField: string | null;
}

Optional is represented like this in TypeScript:

export interface Interface2 {
   optionalField?: string;
}

A field can in theory be both nullable and optional, and the OpenAPI default is that fields are optional, but not nullable. I agree with agilob, that the behavior of the generator is correct.

The linked JSON https://gist.github.com/Dunkhan/604694e5ae47c1162f784f1d3f3a78b9 is missing “required: true” for the non-optional properties.

@agilob I don’t know how the tests look, but they are wrong. By definition nullable is false by default(https://swagger.io/specification/)! Yet not setting nullable at all treats nullable as true.

Your schema must be wrong. Required/optional fields are supported and tested for. In the example schema

https://github.com/OpenAPITools/openapi-generator/blob/master/modules/openapi-generator/src/test/resources/2_0/petstore.yaml

      parameters:
        - name: status
          in: query
          description: Status values that need to be considered for filter
          required: true
          type: array
          items:
            type: string
            enum:
              - available
              - pending
              - sold
            default: available

it generates correct output

add required: true

And to add on top of your comment, a field can be required and nullable. Required means it needs to be specified with a value, and null is a value, as not specifying value will (optionally) use default value from spec. Gonna draw a Venn-diagram for this soon…

With that said, I think this issue can be closed now. @wing328