opentelemetry-js-contrib: UserInteractionInstrumentation create too many traces pr user interaction
What version of OpenTelemetry are you using? 1.4
What version of Node are you using? v18.12.1
What did you do?
Created a plain React app using Vite. Registered a UserInteractionIntrumentation. Clicked anywhere on the page.
What did you expect to see?
One trace (print to the console)
What did you see instead?
4 traces
Additional context
main.tsx
import React from "react";
import ReactDOM from "react-dom/client";
import App from "./App";
import "./index.css";
/* document-load.ts|js file - the code snippet is the same for both the languages */
import {
ConsoleSpanExporter,
SimpleSpanProcessor,
WebTracerProvider,
} from "@opentelemetry/sdk-trace-web";
import { DocumentLoadInstrumentation } from "@opentelemetry/instrumentation-document-load";
import { UserInteractionInstrumentation } from "@opentelemetry/instrumentation-user-interaction";
import { ZoneContextManager } from "@opentelemetry/context-zone";
import { registerInstrumentations } from "@opentelemetry/instrumentation";
const provider = new WebTracerProvider();
provider.addSpanProcessor(new SimpleSpanProcessor(new ConsoleSpanExporter()));
provider.register({
// Changing default contextManager to use ZoneContextManager - supports asynchronous operations - optional
contextManager: new ZoneContextManager(),
});
// Registering instrumentations
registerInstrumentations({
instrumentations: [
new DocumentLoadInstrumentation(),
new UserInteractionInstrumentation(),
],
});
ReactDOM.createRoot(document.getElementById("root") as HTMLElement).render(
<React.StrictMode>
<App />
</React.StrictMode>
);
App.tsx
import { useState } from 'react'
import reactLogo from './assets/react.svg'
import './App.css'
function App() {
const [count, setCount] = useState(0)
return (
<div className="App">
<div>
<a href="https://vitejs.dev" target="_blank">
<img src="/vite.svg" className="logo" alt="Vite logo" />
</a>
<a href="https://reactjs.org" target="_blank">
<img src={reactLogo} className="logo react" alt="React logo" />
</a>
</div>
<h1>Vite + React</h1>
<div className="card">
<button onClick={() => setCount((count) => count + 1)}>
count is {count}
</button>
<p>
Edit <code>src/App.tsx</code> and save to test HMR
</p>
</div>
<p className="read-the-docs">
Click on the Vite and React logos to learn more
</p>
</div>
)
}
export default App
Note: We also tried the same tracing in a real production application. Instead of “only” 4 traces, we got around 50-80 traces pr user click which is insane.
About this issue
- Original URL
- State: open
- Created a year ago
- Reactions: 1
- Comments: 20 (8 by maintainers)
Marking this as
up-for-grabs
to make it explicit that PRs for this are welcome.Note: the owner of this package left the project a long while ago so we’re also looking for people to maintain it long-term. Due to this reviews may take longer than usual.