opentelemetry-java-instrumentation: Inconsistencies with version tags

If you open CHANGELOG file tagged with version 1.3.0 then you see that it does NOT contain a section for 1.3.0 release. Also examples distro example uses javaagent version 1.2.0

How about having repository tagged by a version tag in a state which is completely compatible with that version? Meaning having up-to-date documentation and changelog for that version and having all examples using that version. Yes, it means that releases require a separate PR, but we already have one. Only now we do it post-release, instead of pre-release.

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Comments: 18 (18 by maintainers)

Most upvoted comments

What about this:

  1. We configure PR workflow to build examples only if against main branch (I assume this is possible)
  2. We create a new branch 1.4.x
  3. We do a PR preparing 1.4.0 release against 1.4.x branch, including pointing examples to version 1.4.0
  4. After PR is merged, we tag that commit as 1.4.0.
  5. GHA kicks in, builds and publishes 1.4.0 version. Also builds examples against now published version
  6. We cherrypick PR from 3. to the main branch
  7. Now we have 1.4.0 tag to the exactly right commit and we have a ready branch for patch releases
+3
iNikem on Jul 7, 2021
Read more comments on GitHub
← opentelemetry-java-instrumentation: gRPC trace missing
opentelemetry-java-instrumentation: Kotlin coroutine missing trace →