opentelemetry-collector-contrib: version command prints jaeger errors
Describe the bug
version command prints jaeger errors
./otelcontribcol --version
2022/02/15 09:48:33 proto: duplicate proto type registered: jaeger.api_v2.PostSpansRequest
2022/02/15 09:48:33 proto: duplicate proto type registered: jaeger.api_v2.PostSpansResponse
otelcontribcol version latest
Steps to reproduce
build v0.44.0 and run --version
What did you expect to see?
no warnings
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 18 (17 by maintainers)
This is caused by both the Jaeger receiver and the Coralogix exporter registering the same types:
This is a transitive dependency of the coralogix exporter: https://github.com/coralogix/opentelemetry-cx-protobuf-api/blob/d2a5d0ecf53ef7d38129bc756009169c4c32167f/collector.pb.go#L182-L186
@oded-dd @ofirshmuel, any reason you are not using your own namespaces for that?
Let me ping them one last time and send an email to the email on @oded-dd’s bio:
@oded-dd @ofirshmuel if you don’t actively fix issues from your exporter your component may get excluded from the default build, making it harder to be used. Please take a look at the issue as soon as you can.
If there is no answer, let’s bring this up on the next Collector SIG
Hey! Sorry somehow missed the ping on this issue. Working on the fix in https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/16573
Okay, I have labeled this as
exporter/coralogix
instead of Jaeger, AIUI the fix needs to be done in the Coralogix exporter.We got no answer here or in the email, thus I added this to today’s SIG agenda. cc @oded-dd @ofirshmuel @jpkrohling
@mx-psi yes its still a thing. d397c9878974186e6cf66f904b364d7fc983b691
@frzifus thank you for your help. Adding @povilasv to the thread. He’ll probably also attend it soon, and could give you all the insights you need.
I am surprised that it this exporter workes. 🙅. There are two definitions of
jaeger.api_v2.PostSpansRequest
,jaeger
andcoralogix
. For me it looks likecarologix
is adding the messageMetadata
it the request.As far as I understand, this leads to a few problems:
Metadata
will be a part ofPostSpansRequest
.jaeger
would get extended in the future this could cause issues there too.Any recommendations how to solve this?
cc @oded-dd @ofirshmuel @jpkrohling
Hi @jpkrohling , we are investigating this issue.