ginkgo: flag provided but not defined: -test.timeout (Go 1.13)

I can confirm that replacing

func init() {
	flag.Parse()
}

TestXYZ(t *testing.T) {}

with

func TestMain(m *testing.M) {
	flag.Parse()
	os.Exit(m.Run())
}

TestXYZ(t *testing.T) {}

solves the issue.

As @dfreilich correctly pointed out, the flag provided but not defined error occurs because of https://golang.org/doc/go1.13#testing:

packages that call flag.Parse during package initialization may cause tests to fail

It occurs when flag.Parse is called within the init function. The solution is to move flag.Parse from the init function to somewhere else (e.g. to main or BeforeSuite) For the example above this line must be moved.

An example how to reproduce this error without using ginkgo can be found here. (I can reproduce it with the latest go version go1.13.4 darwin/amd64.)

I agree with @zhubuntu that this is not a Ginkgo issue. I therefore suggest to close this issue.

Looks like it’s a breaking change in Go 1.13. The solution is for users not to call flag.Parse() in an init() function. Please let us know if that does not work for you.

In some cases explicit call for testing.Init() before init() functions in suites may help:

var _ = func() bool {
 	testing.Init()
	return true
}()

func TestApp(t *testing.T) {
	RegisterFailHandler(Fail)
	RunSpecs(t, "App / Suite")
}

any update? are you planning to fix that?

Suspect this is the cause https://golang.org/doc/go1.13#testing

Testing flags are now registered in the new Init function, which is invoked by the generated main function for the test. As a result, testing flags are now only registered when running a test binary, and packages that call flag.Parse during package initialization may cause tests to fail.

@patelpayal, there is a suggested approach here: https://github.com/onsi/ginkgo/issues/602#issuecomment-557313846

I am hitting this error flag provided but not defined: -test.timeout without having to use the flag.Parse anywhere in my codebase. Nor there is any init func My env:

$ go version
go version go1.13.3 darwin/amd64
$ ginkgo version
Ginkgo Version 1.12.3

I think this is the test case problem, not the ginkgoproblem. As kubernetes/kubernetes#82742