onnx-mlir: Warning as error

New issue that continues #936 .

I believe the warning due to the unused parameter in LLVM header files (isPossible) is now fixed in LLVM: https://reviews.llvm.org/rG82ae83a8487df0747195d1abbda11920fda11eb8

However there remain some other unused parameters warnings (but much much fewer).

/workdir/llvm-project/mlir/include/mlir/IR/AttrTypeSubElements.h:412:37: warning: parameter 'derived' set but not used [-Wunused-but-set-parameter]
  412 | void walkImmediateSubElementsImpl(T derived,
      |                                   ~~^~~~~~~

LLVM indicates that it supports our gcc level https://llvm.org/docs/GettingStarted.html#host-c-toolchain-both-compiler-and-standard-library but obviously their tests may not test our specific compiler and/or do not flag warning as error.

@sstamenova suggested that we add a builedbot to mlir to force MLIR developers to address these issues upfront. @gongsu832 was going to look into this.

About this issue

Original URL
State: closed
Created a year ago
Comments: 23 (5 by maintainers)

Most upvoted comments

The LLVM no warning buildbot for zLinux is running and needs some stable time after we upgraded to Ubuntu Jammy. I plan to ask the person in charge to move our bot from staging to production next week if nothing bad happens.

@gongsu832 Thanks, do you have an issue to track your work efforts or are you planning to open one?

As far as I know, there is no issue needs to be opened. The necessary patch to enable the buildbot was already submitted by @sstamenova.

gongsu832 on Apr 18, 2023

@AlexandreEichenberger Seems like a different warning but @sorenlassen opened a draft PR to resolve.

hamptonm1 on Apr 17, 2023

Should we keep this issue open until it is verified then?

I would think so

AlexandreEichenberger on Apr 3, 2023

@cjvolzka Okay I guess I will leave this issue open and close the JIRA issue. This way if anyone wants to make updates or discuss what warnings they are seeing…they can do so here 😃

hamptonm1 on Apr 19, 2023