oneTBB: TBBConfig.cmake should not add '-isystem /usr/local' to gcc's CXX_INCLUDES flag

TBBConfig.cmake: https://github.com/intel/tbb/blob/tbb_2019/cmake/templates/TBBConfig.cmake.in#L57 sets the property INTERFACE_INCLUDE_DIRECTORIES to ${CMAKE_CURRENT_LIST_DIR}/../../../include (which equals /usr/include). It causes that -isystem /usr/lib64/cmake/TBB/../../../include (equal -isystem /usr/include) is being added to gcc’s CXX_INCLUDES flag, what is wrong and causes a compilation error - see https://github.com/pmem/libpmemobj-cpp/issues/508

About this issue

Original URL
State: closed
Created 5 years ago
Comments: 16 (5 by maintainers)

Commits related to this issue

Do not add '-isystem /usr/local' to gcc's CXX_INCLUDES flag Fixes: #195 Refs: pmem/libpmemobj-cpp#508 — committed to ldorau/oneTBB by ldorau 5 years ago
threadingbuildingblocks: Update to 2020.3 Changelog: Intel TBB 2020 Update 3 TBB_INTERFACE_VERSION == 11103 Changes (w.r.t. Intel TBB 2020 Update 2): Changes affecting backward compatibility: - Ch... — committed to NetBSD/pkgsrc by ryoon 4 years ago

Most upvoted comments

The fix was implemented in v2020.2: https://github.com/oneapi-src/oneTBB/blob/v2020.2/cmake/templates/TBBConfig.cmake.in#L60

tbbdev on Mar 30, 2020

@alalek, @RuRo, thank you for so detailed investigation! I checked it on my side too. The fix is planned to be implemented in one of future TBB releases.

AlexVeprev on Feb 6, 2020

This one works:

get_filename_component(COMPONENT_INCLUDE_DIRECTORY "${CMAKE_CURRENT_LIST_DIR}/@TBB_INC_REL_PATH@" ABSOLUTE)
set_target_properties(TBB::${_tbb_component} PROPERTIES
                    INTERFACE_INCLUDE_DIRECTORIES "${COMPONENT_INCLUDE_DIRECTORY}")

Aldrog on Nov 7, 2019

Just changing ABSOLUTE to REALPATH doesn’t seem to work.

RuRo on Feb 4, 2020

Okay, resolving symlinks in TBBConfig.cmake like you suggested worked for me.

RuRo on Feb 4, 2020