priroda: Source rendering is really slow
It is responsible for more than ~90% of cpu time during single stepping through liballoc.
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 19
Commits related to this issue
- Disable source rendering by default (#9) — committed to bjorn3/priroda by bjorn3 6 years ago
- Cache highlighted files (fixes #9) — committed to bjorn3/priroda by bjorn3 6 years ago
- Disable source rendering by default (#9) — committed to vakaras/priroda by bjorn3 6 years ago
- Cache highlighted files (fixes #9) — committed to vakaras/priroda by bjorn3 6 years ago
When the cache is hit, source rendering now requires ~3ms 😃
Yay nice! This project looks pretty cool, good luck with it!
I’ll try and remember to tag you when I add the helper to syntect so you can remove the code from your project if you want, not that it would make any difference. Thanks for the digging about
extend, I’ll switch to that.Oh lol I wrote one almost immediately after I wrote that comment but didn’t submit it since I hadn’t written tests yet, sorry. Looks like we did it in almost exactly the same way, although I haven’t tested if mine compiles or works yet:
Anyway, I’m going to try to get around to contributing it in a PR to syntect soon, along with some tests and a higher level helper that uses it to apply a
StyleModifierto a range of a line.