nushell: nu-0.59.1 build failure

Updated, http://mail-index.netbsd.org/pkgsrc-changes/2022/09/06/msg260136.html

The first thing that comes to mind for me is to lay out a barebones implementation of ProcessInfo, where we can make use of a handy macro that Rust provides called todo!(). This satisfies the compiler’s needs to a certain degree, so that it doesn’t scream back saying the method doesn’t exist. We’ll do this for every function, until we can begin the real work and actually implement the functionalities that ProcessInfo exposes.

I’ll begin by setting up my NetBSD environment, after which I’ll fork the repository and make a draft PR.

@0323pin We plan on releasing 0.68.0 on Sept 6

This was unexpected … yes, looking at the changes, it should have fixed it. I’ll try a build when I find the time and report back. Let’s keep this open until then. Thanks for reaching out.

@fdncred Thanks.

@0323pin if you look at this function, you can see what each platform (Mac, linux, windows) is returning by looking at the cols.push() lines. https://github.com/nushell/nushell/blob/8a9cc33aacf978d95617f79252025a7204d0109d/crates/nu-command/src/system/ps.rs#L69-L149

I could help you achieve that, but I’ll have to setup a new NetBSD environment from scratch, which could take me a while due to my terrible internet connection. Would you like me to do that?

It looks like the easiest solution from here may be to change run_ps() to something like this below, where it checks to see if the process_info is empty, which it should be if it’s coming from other.rs. At least it’s something to play around with.

fn run_ps(engine_state: &EngineState, call: &Call) -> Result<PipelineData, ShellError> {
    let mut output = vec![];
    let span = call.head;
    let long = call.has_flag("long");

    let process_info = nu_system::collect_proc(Duration::from_millis(100), false);
    if !process_info.is_empty() {
        for proc in process_info {
            let mut cols = vec![];
            let mut vals = vec![];

            cols.push("pid".to_string());
            vals.push(Value::Int {
                val: proc.pid() as i64,
                span,
            });

            cols.push("name".to_string());
            vals.push(Value::String {
                val: proc.name(),
                span,
            });

            #[cfg(not(windows))]
            {
                // Hide status on Windows until we can find a good way to support it
                cols.push("status".to_string());
                vals.push(Value::String {
                    val: proc.status(),
                    span,
                });
            }

            cols.push("cpu".to_string());
            vals.push(Value::Float {
                val: proc.cpu_usage(),
                span,
            });

            cols.push("mem".to_string());
            vals.push(Value::Filesize {
                val: proc.mem_size() as i64,
                span,
            });

            cols.push("virtual".to_string());
            vals.push(Value::Filesize {
                val: proc.virtual_size() as i64,
                span,
            });

            if long {
                cols.push("command".to_string());
                vals.push(Value::String {
                    val: proc.command(),
                    span,
                });
                #[cfg(windows)]
                {
                    cols.push("cwd".to_string());
                    vals.push(Value::String {
                        val: proc.cwd(),
                        span,
                    });
                    cols.push("environment".to_string());
                    vals.push(Value::List {
                        vals: proc
                            .environ()
                            .iter()
                            .map(|x| Value::string(x.to_string(), span))
                            .collect(),
                        span,
                    });
                }
            }

            output.push(Value::Record { cols, vals, span });
        }
    }

    Ok(output
        .into_iter()
        .into_pipeline_data(engine_state.ctrlc.clone()))
}

others.rs needs to be here /crates/nu-system/src/others.rs and the lib.rs that needs changing is /crates/nu-system/src/lib.rs