nunit3-vs-adapter: 4.4.0 breaking change for TestAssemblyLoadContext

@OsirisTerje should 4.4 be unlisted? it broke approx 50% of projects i used it on

Hotfix version 4.4.2, nearly identical to the alpha version attached yesterday, is now released. The difference from the attached version is that the Microsoft.Extensions.DependencyModel is not include in the adapter package. It is not needed there, so it was removed. The release notes is here https://docs.nunit.org/articles/vs-test-adapter/AdapterV4-Release-Notes.html (includes some more explanations) and the package is uploaded to nuget https://www.nuget.org/packages/NUnit3TestAdapter/4.4.2. Thanks, everyone for reporting and providing repros!

@SimonCropp @gregsdennis Ok, Ok, you guys win! It’s unlisted!!

v4.4.2 is working thanks!

@Methuselah96 @dave-yotta @daviddenis-stx @paulhickman-a365 Please find attached an alpha version of 4.4.1-alpha.1 and a nuget config file. The alpha version works now on @paulhickman-a365’s repro. Can you all please verify that it also works on your solutions? This alpha uses the 3.15.2 engine, but extended as a 3.15.3-dev engine with added support for .net 8. That is a “Point in time” where I am pretty sure we have a stable version. It will thus not have the fixes that are in the 3.16.X engine, but looking through the issues there I think it will work. The 4.3.1 adapter is based on 3.15.2 engine.
I suggest you add the package to a c:\nuget folder locally, and then add the nuget.config (in the nuget.zip file) to your solution, so that the package is found there.

NUnit3TestAdapter.4.4.1-alpha.1.zip nuget.zip

@daviddenis-stx Yes, I think that’s where it happens, and you see that the MS package was introduced there.

Sorry, Software Factory. Upgrading the nuget package made the factory unit tests go red in any part using some degree of reflection 😃 NUnit3TestAdapter 4.3.1 green results, NUnit3TestAdapter 4.4.0 red results.

It fails in the region below, basically we just created an instance of something using type lookup, then calling the constructor (the instance is created correctly, that is it finds the assembly, the constructor, and invokes it nicely). Then it tries to cast the received “object” to T and fails with InvalidCastException. For example an instance of class MyThing : IMyThing will fail on the cast line, throwing an exception “Cannot cast to IMyThing”. I suspect there’s something weird with the reflexive loading of assemblies and the loading of types in 4.4.0 ?

        T cast;
        try
        {
            cast = (T)instance;

            // Log
            Logger.Debug($"CreateInstance: Instance was casted to {typeof(T)}");
        }
        catch (InvalidCastException invalidCastException)
        {
            // Log
            Logger.Error($"CreateInstance: Instance failed to be casted to {typeof(T)} with exception", invalidCastException);
            return Status.Failure<T>($"Instance failed to be casted to {typeof(T)} with exception", invalidCastException);
        }