nunit-console: Exception encountered unloading AppDomain

I have the same issue, after passing all tests, I get

Warning: System.Threading.ThreadAbortException: Thread was being aborted.
   at NUnit.Engine.Services.DomainManager.DomainUnloader.UnloadOnThread()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()
   at NUnit.Engine.Services.DomainManager.DomainUnloader.UnloadOnThread()
   at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
   at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
   at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
   at System.Threading.ThreadHelper.ThreadStart()

Warning: Exception NUnit.Engine.NUnitEngineException, Exception thrown executing tests

Warning: Unable to unload AppDomain, Unload thread timed out.

Nunit Version: 3.7.0

The trick here is that the tests have already been run and the result reported before this error actually occurs. Since the problem happens “between” test runs - in the case of the console after the sole test run - there’s no place to report it except in an exception of some kind. So, it comes down to a matter of how the console handles the exception.

NUnitEngineException is used to report errors in the engine, which usually mean the test cannot be run. Perhaps we should not be wrapping this exception but let the console handle the CannotUnloadAppDomainException and just issue a warning.

@Rajkumar-Uppala - thanks for following up. You’re correct this has changed from a warning to an error - as you’ll see above, we’re actually considering changing it back!

In my opinion, it’s important to flag it to the user in a non-ignorable way, so that the user can make some attempt to fix the issue. As you’ve seen - it often highlights a more fundamental issue in user-code. It would be better if we could write the results file out however, and just exit with a non-zero code.

NUnitEngineException is used to report errors in the engine, which usually mean the test cannot be run. Perhaps we should not be wrapping this exception but let the console handle the CannotUnloadAppDomainException and just issue a warning.

This suggestion of yours is still the best idea imo @CharliePoole. Just needs someone to do a pull request for it… @Fernell or @jgrossrieder, either of you interested? 😄

I’m traveling at the moment but here’s a quick update. I debugged the process on the CI machine and found the culprit in our tests. One of them was holding an active thread that was blocking the unloading.

I think a good option would be to dump the callstacks of all threads of the agent processes before throwing the unload exception. That would help a lot to find what is going on.

Cheers

Le 12 avr. 2017 1:51 AM, “Michael Letterle” notifications@github.com a écrit :

I just ran into this with our integration test suite and I’m fairly certain it’s because of the 30 second time out, would be handy to have a configurable override for that setting at least…

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/nunit/nunit-console/issues/191#issuecomment-293432900, or mute the thread https://github.com/notifications/unsubscribe-auth/ABrccs7xVM02g5kFDOaHOwusk1ckZ1d7ks5rvBIfgaJpZM4MZOOh .

No worries - I’ll see how I get on!

#116 I’m less worried about, nobodies really been chasing that one. I wanted to get a fix in for this issue, as it keeps attracting people at the moment. 😄