nunit-console: Build hangs when test spawns processes which do not terminate properly
Hi,
After upgrading NUnit and NUnit.ConsoleRunner our build hangs and errors out after the maximum time has exceeded
We came from NUnit version=3.13.2 NUnit.ConsoleRunner version=3.12.0
And went to NUnit version=3.13.3 NUnit.ConsoleRunner version=3.15.0
The main difference is that the project that hangs runs in ApartmentState.STA as it uses some proprietary COM objects. The projects that don’t run in ApartmentState.STA seem to work fine.
The last line in our build log is Results (nunit3) saved as
We are not seeing the committing line, so I guess the nunit-agent.exe process is not terminating correctly Committing…
Due to the proprietary COM objects I am unable to provide a small repro.
I did some more experiments and it turns out to be the NUnit.ConsoleRunner upgrade that was the culprit. I started downgrading it and when I got back to 3.12.0 the test didn’t hang anymore, so from 3.13.0 and onwards it seems broken.
We are running through OpenCover and I added --trace=Debug and ran once with 3.12.0 and once with 3.13.0
"C:\Git\Neuron Stelsel Registratie\packages\OpenCover.4.7.1221\tools\OpenCover.Console.exe" -register:administrator "-target:C:\Git\Neuron Stelsel Registratie\packages\NUnit.ConsoleRunner.3.12.0\tools\nunit3-console.exe" "-targetargs:""C:\Git\NEURON~1\\Vicrea.GVR.UI.Tests\bin\Debug\Vicrea.GVR.UI.Tests.dll"" --trace=Debug --result=""C:\Git\NEURON~1\/NUnitVicrea.GVR.UI.Tests.xml""" -output:C:\Git\NEURON~1\\Vicrea.GVR.UI.Tests.xml -filter:+[Vicrea.GVR.UI]* -excludebyfile:*Reference*;*Generated* -excludebyattribute:System.Diagnostics.CodeAnalysis.ExcludeFromCodeCoverageAttribute;System.Runtime.CompilerServices.CompilerGeneratedAttribute;System.CodeDom.Compiler.GeneratedCodeAttribute -skipautoprops -hideskipped:all -returntargetcode
Logfiles: InternalTrace.29508-version3.12.log nunit-agent_35952-version3.12-.log InternalTrace.15540-version3.12.log nunit-agent_31012-version3.12.log
Kind regards,
Valentijn
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 16 (9 by maintainers)
Commits related to this issue
- Merge pull request #1373 from ValentijnMakkenze/issue-1371-2 Backport #1183 to version315: Eliminate hang due to TcpListener thread — committed to nunit/nunit-console by OsirisTerje 6 months ago
Yes, a new issue with details is most likely best. Threads in the example I worked were not hung but were merely waiting for the process to terminate. Once the process was created as a background process, that happened and all was well. OTOH thread hanging issue tends to be due to very specific causes.
Bear in mind that the engine does not monitor threads created by your tests. Although that was something we once considered, it would have required a fairly large addition to the engine, probably as a new service.
After going down a lot of TCP rabbit holes, I realized that the thread listening for TCP connections was a foreground thread. Making it a background thread resolves the problem.