notion-enhancer: Incompatibility with latest AUR notion-app package

I am the maintainer of the notion-app AUR package and I have made changes to the final install that makes it incompatible with the current notion-enhancer.

What I believe is happening right now is that when notion-enhancer is applied, it tries to patch the binary /opt/notion-app/notion, resulting in a corrupted binary.

I am aware that notion-enhancer is not ready for 2.0.13+ but I think the problems of compatibility with the AUR package could be solved changing https://github.com/notion-enhancer/notion-enhancer/blob/dev/pkg/helpers.js and https://github.com/notion-enhancer/notion-enhancer/blob/dev/pkg/apply.js to the current installation.

As of now, I am extracting the resources right out of the windows build and recreating the electron package myself using these resources. I make some changes to that source code myself so I’m not sure if that will make it outright incompatible with notion-enhancer’s patches.

Anyway, I will try to get notion-enhancer to successfully patch notion-app and will submit it as a PR.

About this issue

Original URL
State: closed
Created 3 years ago
Comments: 32 (20 by maintainers)

Most upvoted comments

Bummer 😿 notion-linux is so awesome, are you open for contributions even if you might not be able to test them?

Yes! Anyway, I can still test stuff in a VM, just it’s a little more awkward than running Linux as my primary OS.

Sidenote, I think the latest version of Notion builds fine on x86, but building the notion-enhanced package is the problem as discussed in this issue (as well as packages for the ARM architecture) and I could probably get notion-enhancer builds working with the changes in #460 - see also https://github.com/davidbailey00/notion-linux/issues/38

valin4tor on Apr 25, 2021

@jamezrin apologies if this is a silly question, I haven’t had a lot of experience with how the AUR works. Would it be worth considering working with @davidbailey00 to create a single, universal Linux port of Notion so there could be consistent releases of Notion and simpler support by things like the enhancer?

The main difference between them is how the packaging is done / the directory in which the application is installed - otherwise they are more or less the same already.

The AUR is inherently tied to Arch, and I’m using electron-installer-redhat and electron-installer-debian to produce packages but there is no official electron-installer-arch, so I’m not sure what else could be done realistically to make the packages more similar, unless we both install notion to /opt for example.

When working in the AUR, the preferred approach normally is to build the package ourselves and install directly to the pkgdir instead of building a rpm, deb, etc package. When a user installs something from the AUR, most of the time it’s going to build from source, or adapt a deb or rpm package to work on Arch.

Taking a look at notion-linux, we do things in pretty much the same way, the biggest difference I see is that notion-linux is using electron-packager and notion-app AUR package is using electron-builder instead.

jamezrin on Apr 25, 2021

@dragonwocky I am afraid #460 doesn’t resolve the issue @jamezrin mentions since it addresses a change that affected a previous version (and concerned only the shell launcher which is a no more) in the new version /opt/notion-app/notion is a binary entry point and enhancer tries to patch it. Thanks for all your works (including @Nek-12 )

materemias on Apr 23, 2021