nan: Stuff V8 will be breaking soon
Skimmed through v8.h@4.8.168, these will be deprecated soon:
- ForceSet -> DefineOwnProperty (prefer CreateDataProperty)
- Function::New -> return MaybeLocal
- Object::SetAccessor -> return Maybe
I don’t think it’s worth breaking compatibility with a new major for this drivel yet. I’d like to keep NAN 2 working for at least a year (given no major overhauls of V8), so I propose aliasing Nan::ForceSet to v8::DefineOwnProperty, ignoring v8::CreateDataProperty, and un-maybefying v8::Function::New and v8::Object::SetAccessor.
About this issue
- Original URL
- State: closed
- Created 9 years ago
- Reactions: 1
- Comments: 18 (1 by maintainers)
And now for a round of “no member named” for all the now-obsolete interfaces, thanks to distributions that jumped on v10 the instant it was released. I’m looking at you, Arch.
Alright, if that schedule will be held, it seems like we could even drop 0.8, 0.10, 0.12 and all of io.js in a year from now, moving on to the regular schedule of supporting two LTSs after that. However, it is still hard to determine such things in advance. It should at least not be necessary to do a new major of NAN until April next year.