ninja: PyPi package of 1.11.1 contains broken binary

The PyPi package that just dropped (Nov 5) is definitely not working - blows up all the tests in the SCons CI build that touch Ninja - looks like a segv from the binary (return code -11). x86_64 - my setup here is Fedora 36, on GitHub the runners provision with Ubuntu. If I just go directly to the place the binary sits and try it:

$ ./ninja --version
Segmentation fault (core dumped)

Rolling back the version:

$ ./ninja --version
1.10.2.git.kitware.jobserver-1

This might be related to #2198, or not - decided to file a new issue since that one was closed.

About this issue

Original URL
State: closed
Created 2 years ago
Reactions: 10
Comments: 21

Commits related to this issue

Meson: Pin ninja version to 1.10.2.4 - Avoid segfault in Linux using `ninja` latest version 1.11.1. - Thanks Vittorio Palmisano @vpalmisano. More info: - https://mediasoup.discourse.group/t/partly-... — committed to versatica/mediasoup by ibc 2 years ago

Most upvoted comments

Note that the ninja project itself doesn’t actually release those PyPI binaries, it’s done totally unofficially by a third-party project that also adds various patches.

On a fresh clone and build of ninja:

$ ./ninja --version
1.12.0.git
$ echo $?
0

So the bug was most likely introduced downstream…

eli-schwartz on Nov 6, 2022

I created https://github.com/ninja-build/ninja/issues/2212 a little while ago, but I suspect it is a duplicate of this issue. On my Linux machine, ninja --version doesn’t generate a seg. fault, but it returns error code 245. That is enough to break meson, which expects that command to return with error code 0.

WarrenWeckesser on Nov 5, 2022