elf: Can't select destination directory

Which @ngneat/elf-* package(s) are the source of the bug?

CLI

Is this a regression?

No

Description

See results from my terminal below

npx @ngneat/elf-cli repo                                                      npm8.2.0  node14.18.2           
? Store name monitors
? Select features Props
? Where you like to put this repository? (Use arrow keys or type to search)
  No results...

I’ve also tried go install tool globally and use elf command directly — same result. Also tried in different environment npm6.14.12 node12.22.1

Please provide a link to a minimal reproduction of the bug

No response

Please provide the exception or error you saw

No response

Please provide the environment you discovered this bug in

No response

Anything else?

No response

Do you want to create a pull request?

Yes

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Reactions: 1
  • Comments: 18 (9 by maintainers)

Most upvoted comments

@kopach I like the second option. We don’t have such a library. Do you want to create a PR?

@strigefleur, there is a search option.

Performance was adversely affected by adding the gitignore functionality. I’ve added an option to provide a different implementation of the fuzzysearch plugin since your convention for folders isn’t commonly used.

https://ngneat.github.io/elf/docs/cli#fuzzypath

Ok. let me explain first the issue. It’s in this line excludeFilter: (nodePath) => nodePath.includes('.') In my case, literally every nodePath will contain dot (.) character as one of my top folders contain it. e.g. path/some.path/path/path. Therefore app folders are excluded for me. So, I have following suggestions:

  1. add fallback path to config, so user at least can select something as fallback default: process.cwd(),
  2. use git to identify what folders to exclude. e.g. I wouldn’t want to see folders like dist/build or similar on the list this will also exclude any folders like .git/. Do you have any git wrapping node libraries added to the project already for reuse in this case?