svg-pathdata: Broken on node 10.0.0
Issue
I use svgicons2svgfont package in https://github.com/itgalaxy/webfont and this package broken on node 10.0.0. After debug i found event https://github.com/nfroidure/svg-pathdata/blob/master/src/SVGPathData.ts#L138 is not fires on node 10.0.0, but work good on other node version. I don’t know maybe it is bug new node or something wrong inside package code.
I’m a gentledev i:
- fully read the README recently
- searched for existing issues
- checked i’m up to date with the latest version of the project
Expected behavior
Works.
Actual behavior
Not works
Steps to reproduce the behavior
Debugging informations
node -vresult:
10.0.0
npm -vresult:
6.0.0
If the result is lower than 6.9.5, there is poor chances i even have a look to it. Please, use the last NodeJS LTS version.
Feature request
It is not feature.
Feature description
It is not feature.
Use cases
- I will/have implement the feature
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Reactions: 1
- Comments: 16 (3 by maintainers)
Thanks for the improvements. @pioug I added you to the collaborators of the repo since you made a significant PR. Feel free to give me your NPM username to be added to the NPM collaborators.
Sorry for the delay. I removed the stream dependency entirely. I’ve also patched svgicons2svgfont to use the updated version. Please close if it works as expected now.
If I remind well using streams synchronously was a feature of Node in its early times. Maybe they expose another API to do so?
Anyway using streams to do synchronous work was conceptually ugly and it was the point of this issue: https://github.com/nfroidure/svg-pathdata/issues/31
That said, it was a bit of work and never took the time to do it. It should take something like a day or 2 I guess…