TAB: Possible memory leak

Server version

Bungeecord (Xcord 1.50 )

TAB version

and 3.2.2+ (maybe other versions too)

Describe the bug

I think TAB plugin has memory leak, this might also be a cause of issue #781 . I did /sparkb heapsummary and /sparkb heapsummary --run-gc-before this is the results: Before garbage collector: After garbage collector:

As we see ChatModifier, TextColor and IChatBaseComponent was not garbage collected, also ChatModifier and IChatBaseComponent has the same number of instances (i think that’s because IChatBaseComponent calls ChatModifier).

Here is my heapdump: https://www.mediafire.com/file/jakqa9e6rh8jq2o/tab_config_and_hpdump.zip/file (i wasn’t able to upload it here, because it’s too big)

Expected behavior

No memory leak, ChatModifier, TextColor and IChatBaseComponent being garbage collected normaly

Steps to reproduce

1. Install bungeecord and spigot servers
2. Add tab and spark plugins to bungeecord.
3. Get some players.
4. Analyze memory (easiest and fastes way to do it is /sparkb heapsummary and /sparkb heapsummary --run-gc-before in my opinion)

Additional info

No response

Checklist

• I am running latest version of the plugin
• I have read the wiki to make sure it’s not an issue with configuration
• I ticked all of the boxes without actually reading them
• I have read the Compatibility wiki page and am not trying to run the plugin on an unsupported server version / platform