go-agent: v3/integrations/nrawssdk-v2: Does not work with the v1.0.0+ releases of AWS SDK v2

@RichVanderwal I implemented @HenriBeck’s suggestion in this PR: https://github.com/newrelic/go-agent/pull/328

It seems to be working well, and is much easier to leverage in our serverless app. Let me know what you think.

@RichVanderwal from my testing today it seems to work for me to extract the transaction from the context with a minimal middleware like this:

func NewRelicMiddleware(stack *smithymiddle.Stack) error {
	return stack.Deserialize.Add(
		smithymiddle.DeserializeMiddlewareFunc(
			"NRDeserializeMiddleware",
			func(
				ctx context.Context,
				in smithymiddle.DeserializeInput,
				next smithymiddle.DeserializeHandler,
			) (out smithymiddle.DeserializeOutput, metadata smithymiddle.Metadata, err error) {
				smithyRequest := in.Request.(*smithyhttp.Request)
				txn := newrelic.FromContext(ctx)

				// The actual http.Request is inside the smithyhttp.Request
				httpRequest := smithyRequest.Request
				segment := newrelic.StartExternalSegment(txn, httpRequest)

				// Hand off execution to other middlewares and then perform the request
				out, metadata, err = next.HandleDeserialize(ctx, in)

				segment.End()
				return out, metadata, err
			},
		),
		smithymiddle.Before,
	)
}

I guess it also would be easy enough to just read from the context in case the txn on the middleware itself is nil just to keep this manual option also available

Fixed in the May Go Agent Release. We’d love to hear feedback from @nc-wittj , @betabandido, @R-NK, @zsrinivas, and @HenriBeck !

Any news on this? This is blocking us from using NR to monitor AWS requests.

Also, I should mention that this is scheduled to be fixed in our April 2021 maintenance release. https://github.com/newrelic/go-agent/issues/250

Thanks, @nc-wittj ! We’ll hand this to our Product Manager to help us prioritize this bug in our NR AWS SDK V2 integration.