kiosk-mode: BREAKING: HA 2023.4 no longer uses app-drawer-layout
breaking all custom cards that use this functionality
please see #beta in Discord.
app-drawer-layout was replaced by mwc-drawer link to Discord: https://discord.com/channels/330944238910963714/427516175237382144/1090920193947074642
I did test the fix that is mentioned, to replace
querySelector("app-drawer-layout partial-panel-resolver")
with
querySelector("app-drawer-layout partial-panel-resolver, mwc-drawer partial-panel-resolver")
but can only replace
app-drawer-layout
in the .js file with mwc-drawer
and that does Not fix the card
About this issue
- Original URL
- State: closed
- Created a year ago
- Comments: 116
For those that do not know how to compile the plugin using the code in the working in progress branch, here you are a gist with the compiled version. You can use this code until the new version is released.
Hi guys. The new version
1.8.1
is released, I have already removed my manual fix and installed it again and it is working properly.Thanks to all of you for the feedback during the testings š
Please, if you notice something, feel free to open an issue with it, closing this issue.
Hi @Mariusthvdb, This pull request contains the necessary changes to make it compatible. Iāll keep it updated if something changes in the development of the new HA version. Regards
Hi @Mariusthvdb, In
HA 2023.4
not onlyapp-drawer-layout
has changed. There are multiple changes there so it cannot be fixed by just changing that selector. Iāll let this issue open until a version that supportsHA 2023.4
is released. RegardsHa, that did work. I guess I forgot the ?v1 thing in the ressources file. Header bar is gone now, sidebar still there. But one problem at a time.
Thanks @pergolafabio and @elchininet
Now will wait for the release with a fix.
Yes @pergolafabio, the issue with the latest release should be fixed when this gets merged and released:
https://github.com/NemesisRE/kiosk-mode/pull/37
I did not see anything
or without explanation
great!
Ive dlād the gist, and all seems to be working swell.
Ill add the new options next (hiding the menu items) and will test those, because that will be a major upgrade!
Really sorry, I am on mobile and couldnāt find the quote code.
The above is not me stating that, but main Frontend dev Bram in Discord
Awesome all fixed with the latest update. Thank you
Morning, Thank you so much for the update, kiosk mode, good job Thank you all
I had to reboot and redownload 1.81 to get old version out of system. Seams to working ok Thanks
Thanks then I will wait I guess for the new release. Patient patient š
I apologize - overlooked them.
For me gist is also working, I have hidden the title bar again , used the gist, removed the 2 files on the kiosk folder, downloaded the gist thereā¦
Restarted , clear cache, thatās it
Not really an option at this moment.
Yes, I know. It is free. I donāt pay money for it. Is that what you mean? I pay for it with my precious time I could spent in doing other things. So i also use my spare time āfor freeā to help the dev to make it work again. So please donāt lecture me about āfreeā and Open-Source - I am fully aware of that. Letās put it this way: it is a taking and giving and hopefully we will all find the right balance.
I will.
ill wait for his return
Hi @akhan999, Please, read the thread, it has been mentioned multiple times that this will be done by the owner of the repo (@NemesisRE) when he is back. For now, your options are already given on the thread. Regards
I just updated the HA IOS app, and swiping for the sidebar works again!
@niekniek89, Please, check this comment.
swiping left is idd an companion issue
@bkr1969, Good to know it. Yes, when the fix is implemented and a new version is released, you just need to delete the manual
JavaScript
file, remove the resource that you created and install the plugin throughHACS
again.OK. That helped. So when the fix is implemented will I need to delete the resource and .js file from /www?
Hi @chicknlil, What you are describing is not expected. Please, open an issue with some screenshots so we can debug there what is happening. Regards
@elchininet thank you,
Hi @Homeassistjoenka, You should wait until the owner of the repo review the changes, merge the branch and release a new version. He should be back around these days. Regards
You were given the instructions four days ago. .
If you canāt do either of those things, thereās really not much anyone else here can do to help you.
Theyāve given you two resources to fix it yourself, I even offered where I put mine to make it work.
If you need more help than that, itās probably best you wait for them to release the fixed version.
I stuck mine in /www/ removed the links in resources to the HACS version, and told it to look at /local/kiosk-mode.js instead. Working fine for me.
Iām running beta7 without any problems.
while weāre at it, and this might be a new FR, so if youād agree, I can write it up separately:
I still have these:
which before, used to do as stated: hide the chevrons in the menu bar. Saves us 2 icons yet againā¦
also, thereās a Help icon in the edit mode that can be ditched:
and the above does work still. I would love to have all of these Dashboard mods in a single package, so maybe have a look?
Btw, I believe you should next rename the custom card, it has grown beyond Kiosk mode onlyā¦
again, thanks!
So this all works just fine!
great, and congrats!
there is but 1 gripe⦠might be an edge case, as I probably will always want tp have at least 1 menu item there, but hiding all menu items takes away the whole triple dot icon.
and, that is the anchor for my menu item template using card-mod-themes:
I would like to ask if anything can be done here, to hide the menu-items, but allow this mod to be there anyways. see:
And notice this
OK, I know you will all hate me for doing this, but believe me it is better to do it now then later š¬ We will rename
mwc-drawer
toha-drawer
during the beta (hopefully next beta) This means all custom cards that where updated tomwc-drawer
should now be updated again toha-drawer
Hi @Jeremyhu102, You would require a bit of knowledge about
Git
and working with terminal commands to build the bundle with the steps that I left before and then you can follow the Manual installation instructions (after uninstalling the original plugin). But as @Mariusthvdb mentioned, you can wait until Home Assistant2023.4
is released and the owner of the repo has released a version to support it.Regards
Thanks @elchininet , you are correct, I had to reload the kiosk-mode.js again by adding
kiosk-mode.js?v1
at the end.The code shows the proper information now:
kiosk mode is working now.
Thanks.
Yes, that would require a change on the README with an statement about what occurs if one hides the sidebar. About enabling the swipe from the plugin, that would require more than simple CSS classes, but depending on the final structure of the elements it could be achievable.
Hi @Mariusthvdb, @NemesisRE should be back soon and he will take care of the releases, for now you can do this to test it:
git clone https://github.com/NemesisRE/kiosk-mode.git
cd kiosk-mode
git checkout prepare_for_ha_2023.4
yarn install
yarn build
dist/kiosk-mode.js
Take into account that branch has all the changes contained in https://github.com/NemesisRE/kiosk-mode/pull/25 https://github.com/NemesisRE/kiosk-mode/pull/26 and https://github.com/NemesisRE/kiosk-mode/pull/28
Regards
amazing, thank you very much, please release! or maybe let us download to test?