nats-server: subscription count in subsz is wrong

SInce updating one of my brokers to 2.0.0 I noticed a slow increate in subscription counts - I also did a bunch of other updates like move to the newly renamed libraries etc so in order to find the cause I eventually concluded the server is just counting things wrongly.

Ignoring the annoying popup, you can see a steady increase in subscriptions.

Data below is from the below dependency embedded in another go process:

github.com/nats-io/nats-server/v2 v2.0.1-0.20190701212751-a171864ae7df

$ curl -s http://localhost:6165/varz|jq .subscriptions
29256

I then tried to verify this number, and assuming I have no bugs in the script below I think the varz counter is off by a lot, comparing snapshots of connz over time I see no growth reflected there not in connection counts nor subscriptions:

$ curl "http://localhost:6165/connz?limit=200000&subs=1"|./countsubs.rb
Connections: 3659
Subscriptions: 25477

I also captured connz output over time 15:17, 15:56 and 10:07 the next day:

$ cat connz-1562685506.json|./countsubs.rb
Connections: 3657
Subscriptions: 25463
$ cat connz-1562687791.json|./countsubs.rb
Connections: 3658
Subscriptions: 25463
$ cat connz-1562687791.json|./countsubs.rb
Connections: 3658
Subscriptions: 25463

Using the script here:

require "json"

subs = JSON.parse(STDIN.read)
puts "Connections: %d" % subs["connections"].length

count = 0

subs["connections"].each do |conn|
  count += subs.length if subs = conn["subscriptions_list"]
end

puts "Subscriptions: %d" % count