DotNetCorePlugins: Assembly loading doesn't work as expected

Describe the bug Loading the assembly from its path creates types differently from expected

To Reproduce Steps to reproduce the behavior:

  1. Using this version of the library ‘0.2.4’
  2. Run tests from https://github.com/godrose/netcore-load
  3. See the error in the test which uses the package as opposed to Assembly.LoadFrom approach

Expected behavior Tests should be green in both cases

Screenshots Irrelevant

Additional context .NET Core pre-3.0, VS 2017, Test Explorer

About this issue

  • Original URL
  • State: closed
  • Created 5 years ago
  • Comments: 23 (8 by maintainers)

Most upvoted comments

New issue, if you don’t mind.

On Mon, Sep 30, 2019, 8:47 AM Gennady Verdel notifications@github.com wrote:

@natemcmaster https://github.com/natemcmaster I’m not sure whether to file a new issue as it seems very similar to the one you closed. Use this repo https://github.com/godrose/netcore-load/tree/master and observe how reverting the changes from the commit godrose/netcore-load@d5e945c https://github.com/godrose/netcore-load/commit/d5e945c1b7f6f5b54faf5d25f19ff1056871bf22 would fail the http://api/warehouse call. This functionality works in one of the old pre-release packages, 0.3.0-beta.36, for example.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/natemcmaster/DotNetCorePlugins/issues/41?email_source=notifications&email_token=AAUSHF77SHOYPSGHRBFWLY3QMINPVA5CNFSM4HJLCU32YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76DZXI#issuecomment-536624349, or mute the thread https://github.com/notifications/unsubscribe-auth/AAUSHF2UE7ADSBALYA6E2RDQMINPVANCNFSM4HJLCU3Q .

@jzabroski congrats on the wedding and enjoy your honeymoon! I’m available to help whenever you’re ready to proceed on this issue.