napari: Pyside 5.15.0 breaking buttons?
đ Bug
just found that all instances of QtModePushButton
werenât working for me. (like the âadd layerâ buttons)
I had pyside 5.15.0 in my environment, and downgraded to 5.14.2 and they worked againâŚ
Can someone else confirm this?
If so⌠we should probably release a patch that pins pyside2 < 5.15
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 31 (26 by maintainers)
nothing figured out yet, just some notes: I tried to create a minimal example of this button problem by ripping out the bare minimum code that gets us from the
Viewer
down to theQtViewerPushButton
in theQtLayerButtons
where the âadd layerâ buttons live⌠but it still âworksâ (in the sense that clicking the buttons calls the callback).minimal example
yep, itâs fixed on 5.15.1⌠see: https://bugreports.qt.io/browse/QTBUG-85487 https://bugreports.qt.io/browse/QTBUG-84852 https://bugreports.qt.io/browse/QTBUG-84493 https://bugreports.qt.io/browse/QTBUG-84879
I donât think the qsocketnotifyer fix in 5.15.1 is going to help us with buttons here. Since I canât reproduce the bug with a minimal example (above) I think the button thing is a more complicated napari-specific problem
Iâm not sure if it is connected with this Issue but Qt 5.15 remove
xcb
libs form build so it fail to run QApplication because of problem with loading plug-in:https://codereview.qt-project.org/c/qt/qtbase/+/253905
I need to run install
on ubuntu to get test not fail with sigabort (on github actions and Azure pipelines).
Iâd go <, much easier to intentionally fix and release when we want then have to go through another emergency release if it breaks again
Rename issue âPySide2 5.15 breaking the worldâ?