nanoc: @item.binary? no longer works
I noticed when upgrading from 4.5.2 to 4.5.3 that @item.binary? no longer works inside the Rules file. It was removed in commit 764bc69d448e479afbf757c06096bb9a016492af
I assume this is not intentional as it is a breaking change and it’s still documented as working. But we should either document the change or, more likely, restore the method (and add a test for it…).
About this issue
- Original URL
- State: closed
- Created 7 years ago
- Comments: 16 (16 by maintainers)
Ah, my mistake. The problem with the need for a global is still present…
My suggestion would be to modify
Symbol#tso that it reads from a fiber-local variable.Ok, I see that it works in one of my other projects. Might be problem with a monkey patch gone wrong, sorry, I’ll reopen after I’ve researched it and I can reproduce it consistently.