mycroft-core: installation of skill confirmation doesn't work from CLI and in general is undocumented

I’m running Linux Mint 18.X
20.2.1
“Hey Mycroft” wake word, mostly defaults

Try to provide steps that we can use to replicate the Issue

For example:

As per https://mycroft-ai.gitbook.io/docs/using-mycroft-ai/installing-new-skills
When a user tries to install a skill using the speaking “Hey mycroft, install <skill>”, or the msm install <skill>, mycroft asks for confirmation but it is unclear how to confirm!

Example:

 msm install Dismissal                                                                skills.log, other                                                                 
 >> Confirming: Shall I install dismissal by ChanceNCounter.                          voice.log                                                                         
yes
>> Sorry, I didn't catch that.
 msm yes                                                                                                                                                                
 >> sorry ...

I think there is a clear bug here … how to confirm on the command line? (I can hear my mycroft in the other room asking for confirmation but I’m not in there to confirm!)

or speak:

Hey Mycroft, install dismissal
>> Confirming: Shall I install dismissal by ChanceNCounter.
Yes

Expected results

I expected the simple response of “yes” or “no” to constitute confirmation on the CLI (or to not be required at all if it was entered as a raw msm command)
If I typed “Hey Mycroft, install <skill”, then typed “yes” or “hey mycroft, yes”, that should constitute as confirmation.
I expect the documentation to reflect this requirement of confirmation and how to do it w/ examples

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 18 (13 by maintainers)

Most upvoted comments

Ah yes, confirmed @krisgesling ; I was too eager in the response validation …

If I do it more carefully:

 uninstall count                                                                                                                                                       
 >> Confirming: Shall I remove count by andlo.

 13:46:06.323 | INFO     |   638 | QuestionsAnswersSkill | Searching for remove count skill
Removing event fallback-query.mycroftai:QuestionQueryTimeout
Removing event fallback-query.mycroftai:QuestionQueryTimeout
Removing event fallback-query.mycroftai:QuestionQueryTimeout
Removing event fallback-query.mycroftai:QuestionQueryTimeout
 13:46:07.073 | INFO     |   638 | QuestionsAnswersSkill | Timeout occured check responses
 13:46:12.551 | INFO     |   638 | msm.mycroft_skills_manager | Best match (1.0): count by andlo

then

Playing WAVE '/home/pi/mycroft-core/mycroft/res/snd/start_listening.wav' : Signed 16 bit Little Endian, Rate 48000 Hz, Stereo
 13:46:15.857 | INFO     |   644 | __main__:handle_record_begin:37 | Begin Recording...

and we type

 yes                                                                                                                                                          --- 16.95
 >> count has been removed

logs final

 13:46:16.597 | INFO     |   638 | msm.skill_entry | Successfully removed count
 13:46:16.598 | INFO     |   638 | msm.mycroft_skills_manager | invalidating skills cache
 13:46:16.643 | INFO     |   638 | mycroft.skills.skill_manager:_unload_removed_skills:322 | removing count.andlo
 13:46:16.676 | INFO     |   638 | mycroft.skills.skill_loader:_execute_instance_shutdown:146 | Skill count.andlo shut down successfully
 13:46:16.677 | INFO     |   638 | msm.mycroft_skills_manager | invalidating skills cache
 13:46:16.680 | INFO     |   638 | msm.mycroft_skills_manager | building SkillEntry objects for all skills
 13:46:18.877 | INFO     |   644 | __main__:handle_record_end:45 | End Recording...
 13:46:20.729 | ERROR    |   644 | mycroft.client.speech.listener:transcribe:239 | list index out of range
 13:46:20.735 | ERROR    |   644 | mycroft.client.speech.listener:transcribe:240 | Speech Recognition could not understand audio

(whoops some errors there at the end tho)

fermulator on Jul 3, 2020

Master is what is currently on devices (it’s about a month old) and has been working well on those (for me at least). But we have found some theoretical issues with the converse system that has been fixed. It may be that you’ve been affected by one of those.

forslund on Apr 22, 2020