fdroidcl: don't ignore config files with json syntax errors
So, I found fdroidcl a couple of hours ago and I want to use it to install bromite on my phone. Bromite has its own repo for fdroid as seen here https://www.bromite.org/fdroid
Here are the steps that I followed.
a) I ran fdroidcl defaults
to make fdroidcl create the ~/.config/fdroidcl/config.json. It worked, and these were its contents
$ cat .config/fdroidcl/config.json
{
"repos": [
{
"id": "f-droid",
"url": "https://f-droid.org/repo",
"enabled": true
},
{
"id": "f-droid-archive",
"url": "https://f-droid.org/archive",
"enabled": false
}
]
}
b) I added bromite’s repo like it is described above, so now the config.json looks like so
$ cat .config/fdroidcl/config.json
{
"repos": [
{
"id": "f-droid",
"url": "https://f-droid.org/repo",
"enabled": true
},
{
"id": "f-droid-archive",
"url": "https://f-droid.org/archive",
"enabled": false
}
{
"id": "bromite",
"url": "https://fdroid.bromite.org/fdroid/repo",
"enabled": true
}
]
}
c) I ran fdroidcl update
to update the index, but only one of them, the stock one for fdroid was updated/downloaded
$ fdroidcl update
Downloading https://f-droid.org/repo/index-v1.jar... done
Why? d) Bromite’s repo was obviously not scanned at all, since searching for bromite returns no results. However searching for something else that exists on the main fdroid repo, does return results
$ fdroidcl search klar
de.marmaro.krt.ffupdater FFUpdater - 68.3.7 (42)
Downloader, installer and updater for browsers from Mozilla
org.mozilla.klar Firefox Klar - 8.0.15 (232)
Get The Privacy Browser. Fast & always private from Firefox, a browser you trust
So what am I doing wrong? Debian testing x64, fdroidcl 0.5.0 running as a simple user
About this issue
- Original URL
- State: closed
- Created 4 years ago
- Comments: 15 (4 by maintainers)
Commits related to this issue
- show error on malformed config.json related issue: #45 — committed to mvdan/fdroidcl by Linus789 a year ago
First of all, you could simply use
$ fdroidcl repo add <NAME> <URL>
instead of editing the file manually. You are missing a comma after the bromite repository.Line 12, just like the line 7. If you fix that comma, the config works.
Admittedly, the tool should be showing the syntax error, instead of ignoring the config entirely.