ngx-sharebuttons: Problem with import of HttpClientModule overwriting interceptors

I’m submitting a … (check one with “x”)

[x] bug report => search for a similar issue before submitting
[ ] feature request
[ ] question

Versions

@angular/cli: 1.4.7
node: 8.7.0
os: darwin x64
@angular/animations: 5.0.0-rc.2
@angular/common: 5.0.0-rc.2
@angular/compiler: 5.0.0-rc.2
@angular/core: 5.0.0-rc.2
@angular/forms: 5.0.0-rc.2
@angular/http: 5.0.0-rc.2
@angular/platform-browser: 5.0.0-rc.2
@angular/platform-browser-dynamic: 5.0.0-rc.2
@angular/platform-server: 5.0.0-rc.2
@angular/router: 5.0.0-rc.2
@angular/cli: 1.4.7
@angular/compiler-cli: 5.0.0-rc.2
@angular/language-service: 5.0.0-rc.2
typescript: 2.5.3

Repro steps

import ShareDirectiveModule in a module (I’ve only seen it in a lazy-loaded module, but I don’t think it is required), when HTTP_INTERCEPTORS are provided at a higher level (for example, in the root app module).

The Issue

The ShareDirectiveModule imports HttpClientModule. According to the angular docs, the HttpClientModule need only be imported once, in the root of the App. One consequence of re-importing the HttpClientModule is that HTTP_INTERCEPTORS are essentially reset both in the ShareDirectiveModule (which isn’t a problem) and for the module which imports the ShareDirectiveModule.

In my App, for example, I found that all of the HttpRequests that were initiated in the module that also imported your module (but nothing at a higher level) ran without my interceptors.

I’m not sure if this is the intended behavior for angular, or if it is an angular bug, but there might be an easy fix: instead of having ShareDirectiveModule import HttpClientModule, amend the docs to have users import HttpClientModule when they import the forRoot() for your module. You may want to do the same with the HttpClientJsonpModule, which adds an interceptor–I’m not sure if it is necessary, though.

Of course, that means that all of your requests will also pass through my interceptor, but it is my responsibility to write the interceptors in a way that doesn’t cause problems for your requests.

Obviously, this is a breaking change, but as the package is written now, it is a problem for users who rely on HTTP_INTERCEPTORS.