addons-frontend: Enable the download button for incompatible clients (link to extension source)

Following on from: https://github.com/mozilla/addons/issues/703

We should look to leave the “install” button enabled for incompatible clients so that users that user privacy.resistFingerprinting set to true can still install add-ons.

screenshot from 2018-04-23 13-18-36

We’ll need to figure out the correct wording in this case as well as make sure the JS API falls-back to the add-on link gracefully for incompatible UAs.

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 9
Comments: 17 (11 by maintainers)

Most upvoted comments

I guess the question was more about the other part:

while In Firefox desktop, the link will trigger an installation

I don’t expect that a “Download file” link triggers an installation, I expect it to trigger a download of the file.

cadeyrn on Sep 22, 2020

I’m also slightly curious why the spacing between the button and the link changes in some screenshots. It’s very close to the button for some of them.

That was a result of a style in place for the mobile view. I’ve fixed that so that in all sizes there is the same 12px gap between the button and the link, and I’ve added the underline:

bobsilverberg on Sep 16, 2020

@jvillalobos Here are some examples of what I’ve done. Note that I made the link grey and lighter to make it less noticeable. Please let me know if you’d like to see style changes.

bobsilverberg on Sep 15, 2020