luxon: Not working with ESM on Node 10

Hey, any chance to have luxon work with Node ESM modules?

import { DateTime } from 'luxon';
           ^^^^^^^^
SyntaxError: The requested module 'luxon' does not provide an export named 'DateTime'
at ModuleJob._instantiate (internal/modules/esm/module_job.js:89:21)

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 5
Comments: 18 (4 by maintainers)

Commits related to this issue

Set `"type": "module"` in package.json for ESM Partial fix for not being able to do e.g. `import {DateTime} from "luxon"`. This *still* won't work, but `import {DateTime} from "my/own/luxon/src/luxo... — committed to L-as/luxon by L-as 4 years ago

Most upvoted comments

Hi 👋!

Node core, Node Module WG member, and creator of esm here. I just wanted to pop in and say

Yes, and soon moving to harmony flag.

There is no set time for Node to move from --experimental-modules to an unflagged implementation. There is also no guarantee on what the final implementation will look like. While the .mjs extension will be used to disambiguate. The extension may not be-the-only-way to disambiguate. There are several ongoing discussions in the working group about what ESM support will look like in Node. Many possible outcomes are incompatible with the current WIP implementation.

The esm loader lets you write ESM today and migrate to whatever the ESM of tomorrow will be. So you can use esm and ship ES modules that are consumable by CJS and compatible with code coverage, bundlers, APM, unit test, and mocking libraries. As Node’s support story solidifies you can tweak, and migrate gradually over.

jdalton on Jul 10, 2018

You can set the main to index and provide both an index.js and index.mjs. Then ESM will pick up the mjs one and the rest of us will use js.

pho3nixf1re on Jun 19, 2018

@ericmorand definitely: but main entry in package.json is not linking src/luxon.js (source) but build/node (transpiled). Here: https://github.com/moment/luxon/blob/19b6c26063498806266ab8b00bfae4d6754e7569/package.json#L59

damianobarbati on May 3, 2018