mocha: after() not called on error

describe 'Test', ->
  after -> console.error 'cleanup is not called'

  describe 'When I do something', ->
    before -> throw new Error 'BAM' # and there is a problem
    it -> assert.ok true

About this issue

Original URL
State: closed
Created 12 years ago
Comments: 44 (16 by maintainers)

Most upvoted comments

well i had this discussion in another issue about trapping signals etc, cleanup in after hooks technically makes little to no sense, but in this case yeah we can definitely get around that

+16

tj on Aug 8, 2012

Found a case in which afterEach doesn’t run for mocha @ 5.2.0 if the async code is deeply nested and throws an error.

Repository here.

import { expect } from 'chai';

global.VALUE = 100;

describe('Suite 1', () => {
  it('passes a simple test', () => {
    expect(true).to.equal(true);
  });
  it('global value is 0', () => {
    expect(VALUE).to.equal(0);
  });
})

describe('Suite 2', () => {
  const anotherPromiseGuaranteedToFail = async () => {
    return new Promise((resolve, reject) => {
      // Modifying the global value here..
      VALUE = -1;
      try {
        throw new Error('failure');
      } catch (error) {
        reject(error);
      }
      resolve();
    });
  };

  // this before all hook is modifying the global value in an asynchronous way
  before(() => (
    new Promise((resolve, reject) => {
      resolve(0);
    }).then(() => {
      return anotherPromiseGuaranteedToFail();
    })
  ));

  it('passes a simple test', () => {
    expect(1).to.equal(1);
  });
})

describe('Suite 3', () => {
  it('global value is 0', () => {
    // fails since afterEach did not set the global value back to 0 after Suite 2
    expect(VALUE).to.equal(0);
  });
});

afterEach(() => {
  global.VALUE = 0;
});

+14

buddyp450 on Sep 30, 2018