mjml: v4.10.0 is breaking our app

Describe the bug

Our build starts to fail while updating mjml to v4.10.0

To Reproduce

Upgrade to v4.10.0 from v4.9.3

Expected behavior

Our builds still pass, and emails are rendered ๐Ÿ‘

MJML environment (please complete the following information):

  • OS: Ubuntu 20.04
  • MJML Version 4.10.0
  • MJML tool used [e.g MJML App]: The MJML API

Additional context

/builds/stordata/cmdb/node_modules/mjml-core/lib/index.js:66
var _classCallCheck2 = _interopRequireDefault(require("@babel/runtime/helpers/classCallCheck"));
                       ^
TypeError: _interopRequireDefault is not a function
    at Object.<anonymous> (/builds/stordata/cmdb/node_modules/mjml-core/lib/index.js:66:24)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Module.replacementCompile (/builds/stordata/cmdb/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Object.<anonymous> (/builds/stordata/cmdb/node_modules/append-transform/index.js:64:4)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/builds/stordata/cmdb/node_modules/mjml/lib/index.js:12:41)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Module.replacementCompile (/builds/stordata/cmdb/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Object.<anonymous> (/builds/stordata/cmdb/node_modules/append-transform/index.js:64:4)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Module.require (internal/modules/cjs/loader.js:952:19)
    at require (internal/modules/cjs/helpers.js:88:18)
    at Object.<anonymous> (/builds/stordata/cmdb/backend/mailer.js:2:390)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Module.replacementCompile (/builds/stordata/cmdb/node_modules/append-transform/index.js:60:13)
    at Module._extensions..js (internal/modules/cjs/loader.js:1092:10)

Looking at https://app.renovatebot.com/package-diff?name=mjml&from=4.9.3&to=4.10.0 I can see this image

I suppose thatโ€™s not what you want ๐Ÿ˜ƒ

About this issue

  • Original URL
  • State: closed
  • Created 3 years ago
  • Reactions: 11
  • Comments: 24 (11 by maintainers)

Commits related to this issue

Most upvoted comments

Thx @doits for the PR! Looking forward for a new release to test the dependency upgrade