turndown: With statements cannot be used with the "esm" output format due to strict mode

> node_modules/domino/lib/sloppy.js:10:4: error: With statements cannot be used with the "esm" output format due to strict mode
    10 │     with(this) eval(code);
       ╵     ~~~~

 > node_modules/domino/lib/sloppy.js:14:6: error: With statements cannot be used with the "esm" output format due to strict mode
    14 │       with(this.document.defaultView || Object.create(null))
       ╵       ~~~~

 > node_modules/domino/lib/sloppy.js:15:8: error: With statements cannot be used with the "esm" output format due to strict mode
    15 │         with(this.document)
       ╵         ~~~~

 > node_modules/domino/lib/sloppy.js:16:10: error: With statements cannot be used with the "esm" output format due to strict mode
    16 │           with(this.form)
       ╵           ~~~~

 > node_modules/domino/lib/sloppy.js:17:12: error: With statements cannot be used with the "esm" output format due to strict mode
    17 │             with(this.element)
       ╵             ~~~~

error when starting dev server:
Error: Build failed with 5 errors:
node_modules/domino/lib/sloppy.js:10:4: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:14:6: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:15:8: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:16:10: error: With statements cannot be used with the "esm" output format due to strict mode
node_modules/domino/lib/sloppy.js:17:12: error: With statements cannot be used with the "esm" output format due to strict mode
    at failureErrorWithLog (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:1224:15)
    at buildResponseToResult (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:936:32)
    at C:\Users\Leonhard Breuer\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:1035:20
    at C:\Users\Leonhard Breuer\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:568:9
    at handleIncomingPacket (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:657:9)
    at Socket.readFromStdout (C:\Users\user\AppData\Roaming\npm\node_modules\vite\node_modules\esbuild\lib\main.js:535:7)
    at Socket.emit (events.js:315:20)
    at addChunk (internal/streams/readable.js:309:12)
    at readableAddChunk (internal/streams/readable.js:284:9)
    at Socket.Readable.push (internal/streams/readable.js:223:10)
    ```
    I get this error, how can I fix it?

About this issue

Original URL
State: open
Created 3 years ago
Reactions: 10
Comments: 33

Commits related to this issue

Add pre-built artifacts as a temporary workaround for yarn v1 builds. See #378. — committed to mixmark-io/turndown by martincizek 3 years ago
add postinstall script to patch broken lib https://github.com/mixmark-io/turndown/issues/378#issuecomment-962089555 — committed to aspectum/scrape-then-ebook by aspectum 2 years ago
chore: fix turndown's sub dependency causing problems when building the app in nextjs 13 with app router https://github.com/mixmark-io/turndown/issues/378 — committed to julienc91/caviardeul by julienc91 9 months ago
chore: fix turndown's sub dependency causing problems when building the app in nextjs 13 with app router https://github.com/mixmark-io/turndown/issues/378 — committed to julienc91/caviardeul by julienc91 9 months ago
refactor: use jsdom for turndownjs instead of relying on domino The domino library looks abandoned and had compatibility issues with the latest nextjs versions. Luckily, turndownjs accepts a JSDOM do... — committed to julienc91/caviardeul by julienc91 9 months ago

Most upvoted comments

same error Version: 7.1.1

Weyker on Jan 25, 2022

I created the patch file:

diff --git a/node_modules/domino/lib/sloppy.js b/node_modules/domino/lib/sloppy.js

index b5d8950..e920db1 100644
--- a/node_modules/domino/lib/sloppy.js
+++ b/node_modules/domino/lib/sloppy.js
@@ -6,19 +6,9 @@
 /* jshint -W085 */
 module.exports = {
   Window_run: function _run(code, file) {
-    if (file) code += '\n//@ sourceURL=' + file;
-    with(this) eval(code);
+    console.log("Window_run removed")
   },
   EventHandlerBuilder_build: function build() {
-    try {
-      with(this.document.defaultView || Object.create(null))
-        with(this.document)
-          with(this.form)
-            with(this.element)
-              return eval("(function(event){" + this.body + "})");
-    }
-    catch (err) {
-      return function() { throw err; };
-    }
+    console.log("EventHandlerBuilder_build removed")
   }
 };

which I deploy to the server by adding “postinstall”: “patch-package”

as a package.json script.

This solved the problem for me.

jb-modist on Nov 5, 2021

@callmeberzerker @cheetahbyte Release 7.1 has been created and published to npm registry. Would you mind to test it, especially with yarn?

It should now be just:

  "dependencies": {
    "turndown": "^7.1.0"
  }

martincizek on Jun 28, 2021

Having the same problem

logycware on Jun 5, 2021

Hi @martincizek

I submitted PR https://github.com/mixmark-io/turndown/pull/457 just to share some results. I added benchmark and happy-dom is unfortunately a lot slower than domino. I also added the html parser parse5 briefly, but its Document interface doesn’t implement function like getElementByID. It’s really only meant for parsing HTML into a list of nodes.

Maybe there are other dies for parser that could be added to compare with domino.

EDIT: I added jsdom for comparison as well.

zirkelc on Mar 23, 2024

There are some packaging changes in the master, so I’d like to ask you to try it first, i.e.:

  "dependencies": {
    "turndown": "github:domchristie/turndown"
  }

If the issue is still present, please provide a minimum buildable example reproducing the issue. Including:

package.json (or other build config file)
your Node.js version
a minimum script
instructions if applicable

Thank you!

martincizek on Jun 14, 2021