EternalTerminal: 6.1.4: build fails

cmake settings:

%cmake \
        -D BUILD_SHARED_LIBS=ON \
        -D BUILD_TESTING=ON \
        -D COTIRE_DEBUG=OFF \
        -D DISABLE_CRASH_LOG=ON \
        -D DISABLE_VCPKG=ON \
        -D FULL_PROTOBUF=OFF \
        -D sodium_USE_STATIC_LIBS=OFF \

and build fails with gcc 11.0.1

[tkloczko@barrel x86_64-redhat-linux-gnu]$ make
/usr/bin/cmake -S/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 -B/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu --check-build-system CMakeFiles/Makefile.cmake 0
/usr/bin/cmake -E cmake_progress_start /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/CMakeFiles /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu//CMakeFiles/progress.marks
make  -f CMakeFiles/Makefile2 all
make[1]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make  -f external_imported/PlatformFolders/CMakeFiles/platform_folders.dir/build.make external_imported/PlatformFolders/CMakeFiles/platform_folders.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/PlatformFolders /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/external_imported/PlatformFolders /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/external_imported/PlatformFolders/CMakeFiles/platform_folders.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make  -f external_imported/PlatformFolders/CMakeFiles/platform_folders.dir/build.make external_imported/PlatformFolders/CMakeFiles/platform_folders.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make[2]: Nothing to be done for 'external_imported/PlatformFolders/CMakeFiles/platform_folders.dir/build'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
[  0%] Built target platform_folders
make  -f CMakeFiles/generated-code.dir/build.make CMakeFiles/generated-code.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/CMakeFiles/generated-code.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make  -f CMakeFiles/generated-code.dir/build.make CMakeFiles/generated-code.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make[2]: Nothing to be done for 'CMakeFiles/generated-code.dir/build'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
[  1%] Built target generated-code
make  -f CMakeFiles/TerminalCommon.dir/build.make CMakeFiles/TerminalCommon.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/CMakeFiles/TerminalCommon.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make  -f CMakeFiles/TerminalCommon.dir/build.make CMakeFiles/TerminalCommon.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make[2]: Nothing to be done for 'CMakeFiles/TerminalCommon.dir/build'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
[ 10%] Built target TerminalCommon
make  -f CMakeFiles/et-lib.dir/build.make CMakeFiles/et-lib.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/CMakeFiles/et-lib.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make  -f CMakeFiles/et-lib.dir/build.make CMakeFiles/et-lib.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make[2]: Nothing to be done for 'CMakeFiles/et-lib.dir/build'.
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
[ 23%] Built target et-lib
make  -f external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/build.make external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/depend
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
cd /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu && /usr/bin/cmake -E cmake_depends "Unix Makefiles" /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4 /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/external_imported/sentry-native/external /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/DependInfo.cmake --color=
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make  -f external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/build.make external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/build
make[2]: Entering directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
[ 23%] Building CXX object external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/breakpad/src/client/linux/handler/exception_handler.cc.o
cd /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu/external_imported/sentry-native/external && /usr/bin/g++ -DHAVE_GETCONTEXT -I/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src -I/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -DUSE_SENTRY -DNDEBUG -fPIC -std=gnu++11 -o CMakeFiles/breakpad_client.dir/breakpad/src/client/linux/handler/exception_handler.cc.o -c /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc
/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc: In function ‘void google_breakpad::{anonymous}::InstallAlternateStackLocked()’:
/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:141:65: error: no matching function for call to ‘max(int, long int)’
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                                                 ^
In file included from /usr/include/c++/11/bits/char_traits.h:39,
                 from /usr/include/c++/11/string:40,
                 from /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.h:38,
                 from /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:66:
/usr/include/c++/11/bits/stl_algobase.h:254:5: note: candidate: ‘template<class _Tp> const _Tp& std::max(const _Tp&, const _Tp&)’
  254 |     max(const _Tp& __a, const _Tp& __b)
      |     ^~~
/usr/include/c++/11/bits/stl_algobase.h:254:5: note:   template argument deduction/substitution failed:
/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:141:65: note:   deduced conflicting types for parameter ‘const _Tp’ (‘int’ and ‘long int’)
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                                                 ^
In file included from /usr/include/c++/11/bits/char_traits.h:39,
                 from /usr/include/c++/11/string:40,
                 from /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.h:38,
                 from /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:66:
/usr/include/c++/11/bits/stl_algobase.h:300:5: note: candidate: ‘template<class _Tp, class _Compare> const _Tp& std::max(const _Tp&, const _Tp&, _Compare)’
  300 |     max(const _Tp& __a, const _Tp& __b, _Compare __comp)
      |     ^~~
/usr/include/c++/11/bits/stl_algobase.h:300:5: note:   template argument deduction/substitution failed:
/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:141:65: note:   deduced conflicting types for parameter ‘const _Tp’ (‘int’ and ‘long int’)
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                                                 ^
In file included from /usr/include/c++/11/algorithm:62,
                 from /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:85:
/usr/include/c++/11/bits/stl_algo.h:3461:5: note: candidate: ‘template<class _Tp> _Tp std::max(std::initializer_list<_Tp>)’
 3461 |     max(initializer_list<_Tp> __l)
      |     ^~~
/usr/include/c++/11/bits/stl_algo.h:3461:5: note:   template argument deduction/substitution failed:
/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:141:65: note:   mismatched types ‘std::initializer_list<_Tp>’ and ‘int’
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                                                 ^
In file included from /usr/include/c++/11/algorithm:62,
                 from /home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:85:
/usr/include/c++/11/bits/stl_algo.h:3467:5: note: candidate: ‘template<class _Tp, class _Compare> _Tp std::max(std::initializer_list<_Tp>, _Compare)’
 3467 |     max(initializer_list<_Tp> __l, _Compare __comp)
      |     ^~~
/usr/include/c++/11/bits/stl_algo.h:3467:5: note:   template argument deduction/substitution failed:
/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/external_imported/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc:141:65: note:   mismatched types ‘std::initializer_list<_Tp>’ and ‘int’
  141 |   static const unsigned kSigStackSize = std::max(16384, SIGSTKSZ);
      |                                                                 ^
make[2]: *** [external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/build.make:280: external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/breakpad/src/client/linux/handler/exception_handler.cc.o] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'
make[1]: *** [CMakeFiles/Makefile2:1079: external_imported/sentry-native/external/CMakeFiles/breakpad_client.dir/all] Error 2
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/EternalTerminal-et-v6.1.4/x86_64-redhat-linux-gnu'

About this issue

  • Original URL
  • State: open
  • Created 3 years ago
  • Comments: 18 (13 by maintainers)

Commits related to this issue

Most upvoted comments

@jubalh is sentry going to accept your patch?

@MisterTea they merged it now.

No worries 😃 I didn’t take it a bad way!

I guess we package maintainers often have to patch our packages, right? Until upstream comments/approves/merges 😃

I had issues with building too on Clear Linux 35210 as it was failing on sentry.

Added ‘(int)’ typecast manually to the file EternalTerminal/external/sentry-native/external/breakpad/src/client/linux/handler/exception_handler.cc as per @jubalh suggestion.

Hacky yes, but it compiled after that lol.

Also if anyone else compiling on CL you need depencies to be installed with.

sudo swupd bundle-add git make c-basic curl zip unzip tar dev-utils-dev

Yet another thing. Would you consider change tagging convention from et-v<version> to just <version> or 'vversion>? Issue is that gitlab/github automatically adds repo name to base directory of the autogenerated tar balls from git tags and last one https://github.com/MisterTea/EternalTerminal//archive/et-v6.1.4.tar.gz has base directory EternalTerminal-et-v%{version}/