hub: pull-request uses wrong base

pull-request used to correctly use the base from my origin remote, but now it seems to want to make pull requests against asmeurer/repo:master (for a branch that I’ve pushed to my fork).

About this issue

  • Original URL
  • State: open
  • Created 10 years ago
  • Comments: 20 (7 by maintainers)

Most upvoted comments

Where does that convention come from?

From my limited understanding of popular conventions for naming git remotes.

Right now the precedence of remote names is this: “upstream”, “github”, “origin”, “<USERNAME>”. The remote most likely to be the canonical repo is “github”, then searches the list from the left; and the one most likely to be your fork is “<USERNAME>”, then searches from the right.

Maybe “github” and “origin” precedence should be switched? It would fix your problems. I would like to see more examples of conventions that various people have while naming remotes to be able to make a decision.