minishift: Missing instructions in "Deploying a sample application"

Per @gbraad feedcack on IRC, the current steps are missing the following instructions:

Step 1: Need to add --allow-missing-imagestream-tags Step 4: Need to change to curl http://nodejs-ex-myproject.<cluster_ip>.nip.io and add a previous step where you retrieve the IP address with minishift ip

I can handle this as a part of the README refactoring or separately. Thoughts?

About this issue

  • Original URL
  • State: closed
  • Created 7 years ago
  • Comments: 33 (33 by maintainers)

Most upvoted comments

I think we can close this issue. There is no issue to take for us on this. ‘–allow-missing-imagestream-tags’ is not needed and I don’t think it is really needed. Also as @budhrg is saying the curl command got replaced by minishift openshift serivce.

namespace is hardcode here - https://github.com/minishift/minishift/blob/master/cmd/minishift/cmd/openshift/service.go#L88 to default.

hmm, bugger. I wonder what happens if you don’t specify it, aka leave it empty

I think we can change it to myproject. WDYT ?

-1, that’s in turn not a good idea.

BTW, we should have this discussion on #342