minishift: Minishift should not use HOMEBREW_GITHUB_API_TOKEN to access api.github.com
General information
- Minishift version: minishift v1.21.0+a8c8b37
- OS: Linux VerteXUbun2 4.15.0-23-generic #25-Ubuntu SMP Wed May 23 18:02:16 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
- Hypervisor: VirtualBox
Steps to reproduce
- Donwload minishift from releases page
- copy minshift to ~/.local/bin (which is in $PATH)
- run
minishift openshift version list
Expected
I expect a list of versions
Actual
i get
Error while trying to get list of available Origin versions: GET https://api.github.com/repos/openshift/origin/releases: 401 Bad credentials []
Logs
~$ minishift -v5 openshift version list
-- minishift version: v1.21.0+a8c8b37
Error while trying to get list of available Origin versions: GET https://api.github.com/repos/openshift/origin/releases: 401 Bad credentials []
Info
I can not reproduce this if i encapsulate minishift in a docker container and it works on any other machine. minishift must use some environment variable or other information source from my local machine, which is passed to github as authorization header or something like that. I tried to set GH_TOKEN to a valid token but it didn’t change anything (See #3564). I can successfully curl, wget and open the URL in my Browser with an authorized session and incognito tab.
About this issue
- Original URL
- State: closed
- Created 6 years ago
- Comments: 16 (11 by maintainers)
Commits related to this issue
- Issue #2625 Removed HOMEBREW_GITHUB_API_TOKEN and GH_TOKEN to access api.github.com — committed to mik-dass/minishift by mik-dass 6 years ago
- Issue #2625 Removed HOMEBREW_GITHUB_API_TOKEN and GH_TOKEN to access api.github.com Signed-off-by: mdas <mrinald7@gmail.com> — committed to mik-dass/minishift by mik-dass 6 years ago
- Issue #2625 Removed HOMEBREW_GITHUB_API_TOKEN and GH_TOKEN to access api.github.com Signed-off-by: mdas <mrinald7@gmail.com> — committed to mik-dass/minishift by mik-dass 6 years ago
- Issue #2625 Removed HOMEBREW_GITHUB_API_TOKEN and GH_TOKEN to access api.github.com Signed-off-by: mdas <mrinald7@gmail.com> — committed to minishift/minishift by mik-dass 6 years ago
- Issue #2625 Removed HOMEBREW_GITHUB_API_TOKEN and GH_TOKEN to access api.github.com Signed-off-by: mdas <mrinald7@gmail.com> — committed to rhnvrm/minishift by mik-dass 6 years ago
and for this reason I would like to reopen this. It would be better to remove this from the code…