milvus: [Bug]: Folly corrupted binary and memalign issues on Apple M2

Is there an existing issue for this?

I have searched the existing issues

Environment

- Milvus version: Master
- Deployment mode(standalone or cluster):
- MQ type(rocksmq, pulsar or kafka):    
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): MacOS 13.5

Current Behavior

I have been trying to build Milvus on M2 and running into issues building folly.

The main issue is that memalign() is not compatible on Mac, Mac supports posix_memalign:

The most likely thing that is going on is that a flag isn’t being set correctly for make, which is true as seen here:

When looking further I noticed that folly is using a corrupted binary:

What are the next steps?

Expected Behavior

No response

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

About this issue

Original URL
State: closed
Created 9 months ago
Comments: 24 (21 by maintainers)

Most upvoted comments

see milvus-io/folly#10

@xiaofan-luan thanks, but I meant could you also submit this fix to folly’s main branch (https://github.com/facebook/folly)? Other projects using folly may have the same problem, so it would be great to also fix it there.

Sure, we will send the pr to folly see if they accept it

xiaofan-luan on Dec 11, 2023