milkdown: [Bug] Multiline headings, GFM-plugin, switches to CommonMark style

Initial checklist

  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything (or linked relevant results below)

Affected packages and versions

@milkdown/preset-gfm

Link to runnable example

No response

Steps to reproduce

Create a Milkdown setup, with an “H1” element, use shift+enter

Expected behavior

Should add, to be aligned with other modules, add a \ newline, not switch to “non-gfm” header style.

# Milkdown 💗 React

what```

### Actual behavior

```# Milkdown 💗 React```

```Milkdown 💗 Reactin\
what
====```

### Runtime

_No response_

### OS

_No response_

### Build and bundle tools

_No response_

About this issue

  • Original URL
  • State: closed
  • Created 2 years ago
  • Comments: 17 (6 by maintainers)

Most upvoted comments

I get your point. I think we do can have such kind of plugins. Thanks for your advise 👍.

But for GFM and commonmark, I think we should make sure the markdown we generated are align the standards. Which means, for example if a user use milkdown to edit README files, than they’ll find something not right when viewing the files on Github or other platforms.

I’ll keep an eye on your suggestion. But currently I’m working on the next major version for Github and may not have bandwidth.