node-notifier: Click event not working when using NotificationCenter with custom terminal-notifier.

I compiled my own terminal notifier to get rid of the terminal icon and put my own, now the ‘click’ event is not triggered.

If I remove the customPath option it works perfectly.

notifier = new NotificationCenter({
    withFallback: false, // Use Growl Fallback if <= 10.8 
    customPath: path.join(__dirname, '..', 'vendor', 'terminal-notifier.app', 'Contents', 'MacOS', 'terminal-notifier')
})

About this issue

Original URL
State: closed
Created 8 years ago
Comments: 47 (13 by maintainers)

Most upvoted comments

FYI terminal-notifier is still maintained and under active development even if there not many new features planned. Quite a lot of new stuff was added in the last few months. I’m not super fast on support but I’ll answer your questions the best I can and when I can 😃

julienXX on Jan 19, 2017

@doronsever I think maybe there’s some misunderstanding around what wait does. wait doesn’t make a sticky notification, it forces things like terminal-notifier til wait until response is returned. Without wait, it will just “fire and forget” but with wait it waits until timeout or user interaction.

mikaelbr on Jan 21, 2017

Thats it. 21 commits later and we’re closing in on a new release. I’d love for all ty try the master branch with their current setup and potentially run all examples on different environments:

npm run example1
npm run example2
npm run example3

You can install the master version by doing

npm i mikaelbr/node-notifier

See all changes and please verify changelog here: https://github.com/mikaelbr/node-notifier/blob/master/CHANGELOG.md#v500-wip

mikaelbr on Jan 19, 2017

Great. I can write some test files which we can run to verify, and also the more important test is to see if it works on existing setup.

Problem with automatic testing and regression testing here is that the project it self is such a integration based project, and the different platforms (would need a sophisticated multi-platform setup for integration tests with screenshots etc, etc). But I think if we just get some to test their existing setup/use cases, we should be good.

I’ll look into finishing v5 after dinner time. 🍽

mikaelbr on Jan 19, 2017

I have that somewhere under le of dust 😃 Windows 10 on it.

lauracpierre on Jan 19, 2017

It’s too long since I’ve published here. Let’s make it happen. The problem is that I need to test on so many different platforms (and some I don’t have access to anymore). But I’ll do all updates I’m planning (new major release) and try to request some testing.

Sorry for taking so long.

mikaelbr on Jan 19, 2017

No worries, just wanted to clarify that terminal-notifier is alive and well 😄

julienXX on Jan 19, 2017

Ah, sorry to assume! It’s been a while since I’ve checked your repo. Sorry for any offence I may have caused 🙏

kurisubrooks on Jan 19, 2017