vscode: vscode.authentication.onDidChangeSessions does not fire for new sessions (1.80 regression?)

Type: Bug

(Note: this could be an API misunderstanding, but then if this is working as expected I’m not sure how to achieve the results I want)

I have a waitForSignIn method that looks something like:

public async waitForSignIn(): Promise<void> {
    if (await this.isSignedIn()) {
        return Promise.resolve();
    }

    return new Promise<void>((resolve) => {
        const disposable = vscode.authentication.onDidChangeSessions(async (event) => {
            if (event.provider.id === 'microsoft' && await this.isSignedIn()) {
                disposable.dispose();
                resolve();
            }
        });
    });
}

After calling waitForSignIn when not signed in, I would expect this method to resolve after, well, signing in.

However, after signing in, what actually happens is…nothing. I have a breakpoint set on the if (event.provider.id === 'microsoft') { line and it never gets hit.

Elsewhere in the codebase, there’s another onDidChangeSessions listener, and as far as I can tell, it only gets called when I completely log out of a provider (at which point the listener is called twice as many times as the number of extensions that were using the provider).

VS Code version: Code - Insiders 1.80.0-insider (4649b5333370139d161e7b5d4f78ca13741efa35, 2023-06-28T08:01:04.380Z) OS version: Windows_NT x64 10.0.22621 Modes: Remote OS version: Windows_NT x64 10.0.22000 Remote OS version: Windows_NT x64 10.0.22000

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30776702
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
pylantcb52:30590116
pyind779:30611226
vscrpc:30624061
pythonsymbol12:30651887
2i9eh265:30646982
showlangstatbar:30737417
pythonms35:30671666
03d35959:30757351
ecj1e332:30687743
pythonfmttext:30716741
pythoncmvfstr:30726892
fixshowwlkth:30771523
showindicator:30766888
pythongtdpath:30726887
bgfeh915:30769767
gsofa:30778558
e440d664:30776459
welcomedialog:30778555
pythonnosmt12:30773574
pythonidxpt:30768918
pythondjangots:30768917
pythonnoceb:30776497
copilotsettingc:30767685
e537b577:30772214
asynctokenver:30776452
dsvsc013:30777762
dsvsc014:30777825