vscode: VSCode cannot jump to the result file row if got results too fast from vscode-msr + VsCode cannot de-duplicate results correctly

  • VSCode Version: 1.44.2
  • OS Version: Window 10 Enterprise 1909 build 18363.778

Issue summary

  • vscode cannot correctly de-duplicate results of Go To Definition from 2 definition providers.
  • vscode cannot correctly de-duplicate results of Find All References from 2 providers.
  • vscode cannot correctly jump to the definition location + progress bar keeps moving, if has 2+ definition providers, when vscode-msr found the definition while other official/professional extensions not found it:

Steps to Reproduce:

  1. Install a tiny vscode extension: vscode-msr (less than 1 minute, about 1.6MB)
  2. To fast verify it: Open a small project (or a sub-folder) to let vscode-msr can find results in 3~50 milliseconds. ( I just cloned vscode-python and reproduced this issue as screenshot below)
  3. Test “Go To Definition” (Press F12 or menu Go To Definition) for a function or method in a code/script file like C#/Python/C++/Java/Powershell etc.
  4. Test “Find All Reference” for a function or method etc.

See my test screenshot below with just cloned vscode-python source code to test:

  • File path: pythonFiles/install_debugpy.py
  • Test finding: _download_and_extract + DEBUGGER_DEST

Additionally:

  • You can uncheck msr.quiet in User settings to auto show searching info each time in MSR-Def-Ref channel in OUTPUT tab.
  • You can press Alt+F2 (or press F1 -> msr toggle enable finding) to temporarily enable or disable vscode-msr finding definition.

Does this issue occur when all extensions are disabled?: No -> after I disabled only the corresponding language extension (like vscode-python in my test case)

1. Cannot jump to the location of only one result, progress bar keeps moving:

image

2.Cannot de-duplicate correctly for results of Go To Definition :

image

3. Also got duplicate results of Find Alll References:

This time the bug location is much obvious to start tracing at here: CommandsConverter#CREATE image

About this issue

  • Original URL
  • State: closed
  • Created 4 years ago
  • Comments: 17 (5 by maintainers)

Commits related to this issue

Most upvoted comments

1 issue, 1 topic please