vscode: toggleMaximizedPanel not working for side pannel
Issue Type: Bug
The command workbench.action.toggleMaximizedPanel will toggle the panel instead of the side panel.
The expected behavior should be toggle the side panel if side panel is in use.
VS Code version: Code - Insiders 1.64.0-insider (45060913204279d4ecfe0575ca69d68211fb3798, 2022-01-26T05:26:19.708Z) OS version: Darwin arm64 21.2.0 Restricted Mode: No Remote OS version: Linux x64 5.4.0-96-generic Remote OS version: Linux x64 5.4.0-96-generic
System Info
| Item | Value |
|---|---|
| CPUs | Apple M1 (8 x 24) |
| GPU Status | 2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled |
| Load (avg) | 3, 3, 3 |
| Memory (System) | 8.00GB (0.14GB free) |
| Process Argv | –crash-reporter-id d9f6c2c8-fd52-4c94-a957-4a6395335605 |
| Screen Reader | no |
| VM | 0% |
| Item | Value |
|---|---|
| Remote | SSH: batiquitos |
| OS | Linux x64 5.4.0-96-generic |
| CPUs | AMD EPYC 7542 32-Core Processor (128 x 1483) |
| Memory (System) | 503.75GB (1.85GB free) |
| VM | 0% |
| Item | Value |
|---|---|
| Remote | SSH: batiquitos |
| OS | Linux x64 5.4.0-96-generic |
| CPUs | AMD EPYC 7542 32-Core Processor (128 x 1483) |
| Memory (System) | 503.75GB (1.85GB free) |
| VM | 0% |
Extensions (29)
| Extension | Author (truncated) | Version |
|---|---|---|
| html-snippets | abu | 0.2.1 |
| vsc-material-theme | Equ | 33.2.2 |
| vsc-material-theme-icons | equ | 2.2.1 |
| better-cpp-syntax | jef | 1.15.10 |
| jupyter-keymap | ms- | 1.0.0 |
| remote-containers | ms- | 0.215.0 |
| remote-ssh | ms- | 0.70.0 |
| remote-ssh-edit | ms- | 0.70.0 |
| remote-wsl | ms- | 0.64.2 |
| latex-support | tor | 3.10.0 |
| vim | vsc | 1.21.10 |
| material-theme | zhu | 3.13.16 |
| path-intellisense | chr | 2.7.0 |
| gitlens | eam | 11.7.0 |
| vscode-diff | fab | 1.4.2 |
| seito-openfile | Fr4 | 1.8.8 |
| copilot | Git | 1.7.4688 |
| vscode-pull-request-github | Git | 0.35.2022012609 |
| intellij-idea-keybindings | k– | 1.5.0 |
| MagicPython | mag | 1.1.0 |
| python | ms- | 2021.12.1559732655 |
| vscode-pylance | ms- | 2022.1.3 |
| jupyter | ms- | 2022.1.1001614873 |
| jupyter-keymap | ms- | 1.0.0 |
| jupyter-renderers | ms- | 1.0.6 |
| vscode-yaml | red | 1.3.0 |
| code-spell-checker | str | 2.1.4 |
| python | tht | 0.2.3 |
| vscodeintellicode | Vis | 1.2.16 |
(5 theme extensions excluded)
A/B Experiments
vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyl392:30422396
pythontb:30258533
pythonptprofiler:30281269
vsdfh931:30280409
vshan820:30294714
pythondataviewer:30285072
vscod805cf:30301675
pythonvspyt200:30323110
bridge0708:30335490
bridge0723:30353136
vsaa593cf:30376535
pythonvs932:30404738
wslgetstarted:30421357
vscop804:30404766
vscop453:30404998
vsclayoutctrt:30405800
azactmsal:30409287
pythonvspyt640:30426300
vsbas813:30426126
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Reactions: 42
- Comments: 18 (4 by maintainers)
FYI: I proposed a general flexible solution to this in #141349.
@xvjiarui with the side panel functioning somewhat like a side bar and the panel still remaining at the bottom, there needs to be a new command for toggle maximized side panel.
There is no regression, this is a new feature request. You can still move the panel to the right/left and maximize as you could before the Secondary Side Bar existed. A new feature request should be filed for the Secondary Side Bar as this issue was created when the Side Panel was intended to replace panel movement. We have since changed courses on that.
@sbatten does this mean there will not be support for maximizing the auxilliary bar at all? As @conradob mentioned, right now we can only toggle it, whereas before we could both toggle and maximize it. This seems like a regressions and breakage of user flows.
@sbatten @wraiford
workbench.action.toggleAuxiliaryBardoes not have the same expected behaviour asworkbench.action.toggleMaximizedPanel. We are still unable to maximize the auxiliary bar as we have with the panel.A use case is to have the terminal on the auxiliary/side panel (on the right) and the remaining views on the standard panel (at the bottom)
There is no way to toggle maximize the auxiliary side panel.
I rolledback to 1.63.0. honestly no idea what to do next. my ideal flow is broken =(
@sbatten you’re breaking the workflow for all of those people who rely on this functionality. This is not something that you can put in the backlog. It is a breaking change!
Yeah I think this is a pretty big oversight - as far as I can tell, I have zero ability to maximize anything located in the new side panel.
Hi @sbatten
Before 1.64.0, the behavior is toggle the side panel if side panel is in use. So I guess there is a BC breaking in 1.64.0?