vscode: The --wait switch no longer works

I’ve been using VSCode as my Git editor for a while, with the following value for core.editor:

'C:\Program Files (x86)\Microsoft VS Code\Code.exe' --wait

It was working fine, but now Git keeps waiting after I closed the editor tab, so I suspect the process Git is waiting for is still running when it should stop.

(Using VSCode 1.28.1)

About this issue

Original URL
State: closed
Created 6 years ago
Reactions: 3
Comments: 15 (11 by maintainers)

Most upvoted comments

@bpasero That is exactly the problem. There’s already an issue in the Git package: https://github.com/git-for-windows/git/issues/1875

joaomoreno on Oct 22, 2018

wait, you are not using the actual code.exe in program files to do this right? That will not work, you must be using our “code” global command.

The machine where I saw it happening was the demo booth machine, which wasn’t set up by me. It was also a shiny new windows, with pretty much nothing installed but (1) Code and (2) Git. Afaik, Git can automatically configure Code as the default editor. It is possible that they are doing the wrong thing and using code.exe as the editor value. I can’t check any more, since I’m not with the machine anymore…

If this is true, we might wanna follow up with the Git for Windows guys and get them to do the right thing.

joaomoreno on Oct 18, 2018

Everyone, what is your exact windows version?

Windows 10 64bit v1803

Does it reproduce without configuring any settings?

What kind of settings do you mean? The Git editor settings are as described in the first message (I think this setup was done by the Git for Windows installer)

That will not work, you must be using our “code” global command.

Ah, that works! Thanks!

thomaslevesque on Oct 18, 2018

As a workaround you can add -n switch to force opening a new VS Code window.

rafalborczuch on Oct 16, 2018