vscode: Terminal process title not updating

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.74.3 (Universal)
  • OS Version: Darwin arm64 22.2.0

Steps to Reproduce:

  1. Launch a terminal tab from the integrated terminal
  2. Start a process (e.g. node REPL)

I started noticing recently that the terminal tab titles don’t update with new processes anymore:

SCR-20230130-gtn

The title on the right remains zsh and not node. This occurs in both zsh and bash terminals. My terminal.integrated.tabs.title is set to ${process}. Changing it to ${process} test adds the word test correctly but doesn’t update the process.

About this issue

  • Original URL
  • State: closed
  • Created a year ago
  • Reactions: 8
  • Comments: 22 (8 by maintainers)

Most upvoted comments

Looks like it’s fixed now!

Version: 1.84.0
Mac OS

image

Does it require a specific terminal.integrated.tabs.title? I have ${process} set.

@alexturpin ${process} is correct (to see node etc.), so yes it looks like the fix hasn’t worked for you

@Tyriar are there any more details on this? 🙏

Reverting the node-pty update as it caused tests to fail

Is there a way to fix the tests for that PR?

@NoelAbrahams that is indeed a bug, but it’s separate to this one as this is macOS only. Created https://github.com/microsoft/vscode/issues/192771 to track that.

Yeah switching to proc_name only retrieves info about the target PID, in this case the top level shell that got forked. If we want info on the current running process in the group then we would need to switch back to using sysctl. Originally, I switched this because of an issue with the control terminal being not correctly assigned leading to the API always returning the default root process kernel_task which should now be addressed with https://github.com/microsoft/node-pty/pull/589, let me see if I am able to revert the change.