vscode: skipFiles not working for the latest nightly build

VSCode Version: 1.48.0-insider
OS Version: MAC Catalina 10.15.6

Debugger is stepping into <node_internals>/domain.js, <node_internals>/internal/_stream_writable.js

Steps to Reproduce:

Create new launch.config with following value.

{
    "name": "Launch & Attach to App",
    "type": "pwa-node",
    "request": "launch",
    "runtimeExecutable": "sam",
    "runtimeArgs": [
        "local",
        "invoke",
        "-e",
        "${workspaceFolder}/event.json",
        "-n",
        "${workspaceFolder}/env-vars/local.json",
        "-d",
        "5858",
        "-t",
        "${workspaceFolder}/template.yaml",
        "HelloWorld",
        "--region",
        "us-west-2"
    ],
    "attachSimplePort": 5858,
    "localRoot": "${workspaceFolder}/",
    "remoteRoot": "/var/task",
    "stopOnEntry": false,
    "skipFiles": [
        "${workspaceFolder}/node_modules/**/*.js",
        "<node_internals>/**"
    ]
}

Run the debugger

Does this issue occur when all extensions are disabled?: Yes

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 22 (11 by maintainers)

Most upvoted comments

As suggested by you I got the latest nightly build for the debugger. I am still getting the issue in my company’s project where the debugger is stepping into <node_internals> methods. I even created separate project to try to reproduce the issue but couldn’t. As far as node_modules is concerned debugger is skipping it so we are good for that. I have emailed you the latest trace file in case you try to investigate further.

queston02 on Sep 10, 2020

Nope. I just debugged my project and got the issue. I got the screen shot also but cannot attach it here. In screen shot you could see it going into domain.js file of node_internals. Below is my launch.config

{
    "type": "node",
    "request": "attach",
    "name": "Attach by Process ID",
    "processId": "${command:PickProcess}",
    "skipFiles": [
        "${workspaceFolder}/node_modules/**/*.js",
        "<node_internals>/**/*.js"    
    ]
}

Below is VS Code Insider details:-

Version: 1.49.0-insider Commit: b6d4fec3714ff897f72c1dab8cc02b7421a8f131 Date: 2020-09-01T05:48:29.841Z Electron: 9.2.1 Chrome: 83.0.4103.122 Node.js: 12.14.1 V8: 8.3.110.13-electron.0 OS: Darwin x64 19.6.0

queston02 on Sep 2, 2020