vscode: Settings sync - Cannot dismiss "Configure..." quick pick dialog

That’s definitely an option, would look something like this for the branch picker that has this enabled:

An alternative would be to place a close button inside of the text input. We already use actions inside of inputs (find toggles, clearing search in settings, etc.) so this wouldn’t stretch too far from our patterns, though we do use the “clear-all” icon and someone could confuse the “close” with that

Couple definitions:

If there is no title defined and there are no title bar buttons defined, then no title bar is shown. My proposal would be:

if ignoreFocusOut is true and there is a title bar shown, show an additional x option by default that will do the same as hitting ESC. if ignoreFocusOut is false and there IS a title bar, then don’t show the x if ignoreFocusOut is true and there is NOT a title bar, then don’t show the x

thoughts?

I’m not sure we need it with the configure action when sync is already on.

I am fine doing that.