vscode: Regression: Port forwarding fails while working with remote SSH

Can confirm. Facing the same issue on Mac (Client), Fedora (Remote).

Version: 1.82.0
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Date: 2023-09-06T22:09:41.364Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Darwin x64 21.6.0

Rolling back to 1.81.1 fixes it and everything works perfectly !

Version: 1.81.1
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:20:33.924Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Darwin x64 21.6.0

@Ashesh3 the other parts were in the closed-source ssh extension

@LeonardoEmili your issue is unrelated, please open a new issue and share the complete Remote SSH output

@alexr00 I have only been able to reproduce it with real-word projects for now. I believe the difference lies in the size transferred, as requests start to hang only after the first few 100s of KB (or few MBs?) are transferred from the server. I can try to create a minimal reproducible example based on the repo you linked when I get back from work in a few hours.

Probably unnecessary, but reporting here in case any user comes across this issue. For me, vscode automatically updated to 1.81.2 and I was getting the following error, nothing worked (removing the local nor remote .vscode directory, restarting the server, reinstalling vscode) but I had to manually downgrade to 1.81.1. The error I was getting below:

[10:19:08.867] Failed to parse remote port from server output
[10:19:08.868] Resolver error: Error: 
	at g.Create (/Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:637876)
	at t.handleInstallOutput (/Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:635279)
	at t.tryInstall (/Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:756875)
	at async /Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:717467
	at async t.withShowDetailsEvent (/Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:720720)
	at async C (/Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:714381)
	at async t.resolve (/Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:718116)
	at async /Users/leonardoemili/.vscode/extensions/ms-vscode-remote.remote-ssh-0.106.3/out/extension.js:2:901786
[10:19:08.869] ------

@connor4312 I understand that you rolled back to the previous SSH behaviour since version 1.81.1 has been removed from the releases section.

@connor4312 Your linked PR closed this issue even though the PR says, “Part 1 of fixing”, just checking if it was closed accidently.

@alexr00 I’m downgrading this from a candidate since we backed out the SSH change that exposed this issue.

Excellent, thanks for confirming. I will duplicate the other issue into this one.

Thanks @alexr00, I was able to repro a problem with those steps. THat looks the same as #192627

However @Ashesh3 it’s hard for me to tell just based on “Try to access it on the current PC” whether this is the same problem you’re hitting. Can you describe your problem in more detail, or grab a screencap of what you hit? https://gifcap.dev/ is useful

Note that we have rolled back the change that probably caused this issue, so to reproduce it again you may need to add "remote.SSH.useExecServer": true to your user settings. Thanks!

@connor4312 Hey, apologies for the non-descriptive steps to replicate the issue. What @alexr00 mentioned above is exactly the steps that pertains to the issue I have and the case which @au2001 mentioned above is specifically relevant to me. Running the server node process, then changing the contents of the server file followed by restarting the server (it happens automatically in my case) causes the browser to get stuck in an infinite loading state.

(Note: The below is reported with "remote.SSH.useExecServer": true as per your suggestion)

On my windows vscode client (connected to macOS host):

• Start vite server
• Make a file change while the server is running
• Terminate the process (ctrl+c)
• Start the vite server again
• Now, the browser will not serve any requests from the same port even after vite has started completely and is ready to serve
• It basically hangs in a loading state

Setting "remote.SSH.useExecServer": false fixes the above issue for me. Everything loads up instant no matter how many times and when i restart my vite server.

@alexr00 I think I have a repro

Can confirm this reproduces the exact problem I was having. Using npx nodemon server.js at step 3 and updating the server.js file instead of steps 5 & 6 also works, which is probably the most common scenario for this bug.

@connor4312 Note that we have rolled back the change that probably caused this issue, so to reproduce it again you may need to add "remote.SSH.useExecServer": true to your user settings. Thanks!

Don’t know about @Ashesh3 & others, but with "remote.SSH.useExecServer": false in my user settings, all issues are fixed on my side. Thanks for this tip!

Thanks @alexr00, I was able to repro a problem with those steps. THat looks the same as https://github.com/microsoft/vscode/issues/192627

However @ashesh3 it’s hard for me to tell just based on “Try to access it on the current PC” whether this is the same problem you’re hitting. Can you describe your problem in more detail, or grab a screencap of what you hit? https://gifcap.dev/ is useful

Note that we have rolled back the change that probably caused this issue, so to reproduce it again you may need to add "remote.SSH.useExecServer": true to your user settings. Thanks!

I think I have a repro:

1. Start with https://github.com/microsoft/vscode-remote-try-node
2. Add a lot more text to the res.send
3. npm run start
4. Open the page in the browser
5. kill the process form step 3
6. npm run start again
7. Open the page in the browser. It will spin indefinitely.

Same happened to me on mac Ventura (client) and ubuntu (Remote)

any chance this get a hotfix/recovery? @alexr00

same issue here:

Version: 1.82.0 (user setup)
Commit: 8b617bd08fd9e3fc94d14adb8d358b56e3f72314
Date: 2023-09-06T22:07:07.438Z
Electron: 25.8.0
ElectronBuildId: 23503258
Chromium: 114.0.5735.289
Node.js: 18.15.0
V8: 11.4.183.29-electron.0
OS: Windows_NT x64 10.0.22621

Everything works fine on the previous version:

Version: 1.81.1 (user setup)
Commit: 6c3e3dba23e8fadc360aed75ce363ba185c49794
Date: 2023-08-09T22:22:42.175Z
Electron: 22.3.18
ElectronBuildId: 22689846
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: 10.8.168.25-electron.0
OS: Windows_NT x64 10.0.19045

I now have to backup my current vscode installer every single time before installing an update, just to be safe. It’s really unfortunate.