vscode: Redo created file fails

Create a new file in the explorer
from the window menu, run Edit > Undo. File is gone ✔️
from the window menu, run Edit > Redo. Nothing happens

About this issue

Original URL
State: closed
Created 4 years ago
Comments: 16 (16 by maintainers)

Commits related to this issue

Prompt when hitting a different UndoRedoSrouce when undoing (#111640) — committed to microsoft/vscode by alexdima 4 years ago
explorer: update creation labels #111640 — committed to microsoft/vscode by isidorn 4 years ago

Most upvoted comments

I agree with you @isidorn . My concern is that we might have to do a recovery build if many people are confused and we might have to live with this until end of January.

We could do the following: undoing from the editor will undo operations inserted by the explorer, but if it hits an undo-redo element inserted by the explorer, it could first prompt to confirm.

alexdima on Dec 2, 2020

@alexdima I see the issue.

I was pondering about this a bit more and my feeling is:

The current solution seems to be a bit confusing for the users (since all 3 testers filled some version of “Undo is not working because I have no clue where focus is”).
Changing the behavior that the Explorer Undoes without it having focus is dangerous as @alexdima also pointed out.
Also as @alexdima pointed out: cmd+z from the Editor should not be able to undo operations originating from the explorer. That should at least make the current situaton less confusing - since currently some operations can be undoable and some can not

As I mentioned in other issues, I would probably not change anything here for Endgame, and in Debt week we can decide on a stragety.

My other concern is even if we change the third bullet point I think users will still be confused by undo not working in Explorer since the Explorer passes focus into the editor in some cases automatically.

isidorn on Dec 2, 2020