vscode-pull-request-github: GitHub PR eventually hangs due to `git+ssh://` scheme being in a remote
Update
We’ve learned some more info in this issue… please jump to https://github.com/microsoft/vscode-pull-request-github/issues/3675#issuecomment-1171360048
Original
Does this issue occur when all extensions are disabled? N/A because this is an extension bug
-
VS Code Version: Version: Version: 1.68.1 (Universal)
-
OS Version: Mac os 12.3.1 (21E258)
Steps to Reproduce:
We have an enterprise account but not a custom url (we just use normal github.com)
The problem is that the extension sort of assumes you have a custom URL. You can see by the code here that it hits ${apiUri.scheme}://${apiUri.authority}/api/v3${path}
However in normal api.github.com
(which is what I used as my enterprise server url) there is no /api/v3/
so it does not work.
My proposal:
- Have a different boolean setting “use github enterprise” that does the enterprise PAT dance even without a custom URL
- If the custom URL is set, use that with /api/v3/
- Else use normal
api.github.com
without custom url
Happy to give more info if needed. Also, if there’s some way to develop on this extension without having to compile whole vs code, I’d be happy to implement my proposal.
Thanks!
About this issue
- Original URL
- State: closed
- Created 2 years ago
- Comments: 24 (10 by maintainers)
Commits related to this issue
- Fix #152346: Allow login with PAT/enterprise on public github server Not every enterprise client has a private server url. The public api url paths vary slightly. This makes github pull requests and ... — committed to errietta/vscode by errietta 2 years ago
- Fix #152346: Allow login with PAT/enterprise on public github server Not every enterprise client has a private server url. The public api url paths vary slightly. This makes github pull requests and ... — committed to errietta/vscode by errietta 2 years ago
- Fix #152346: Allow login with PAT/enterprise on public github server Not every enterprise client has a private server url. The public api url paths vary slightly. This makes github pull requests and ... — committed to errietta/vscode by errietta 2 years ago
- Fix #152346: Allow login with PAT/enterprise on public github server Not every enterprise client has a private server url. The public api url paths vary slightly. This makes github pull requests and ... — committed to errietta/vscode by errietta 2 years ago
- Support `git+ssh://` scheme being in a remote Fixes #3675 — committed to microsoft/vscode-pull-request-github by alexr00 2 years ago
Sure please ping me when it’s released and I’ll try out
@errietta the fix will be available in the pre-release build of GitHub Pull Requests and Issues by Friday. It ended up being suspiciously simple, so if you have a chance to try it out after Friday it would help to confirm that the fix is good!
@errietta makes sense! I will add support for it.