vscode: Organize Imports broken in 1.73.0

This will ship with 1.73.1

Sounds like it’s likely caused by an extension

@mjbvz Even if that’s the case, this doesn’t happen on previous VSCode versions.

Due to source.organizeImports not respecting trailing commas ( #98123 - unresolved), I also use source.fixAll.eslint to fix it. However, the latest release cycles repeatedly.

Thanks for the example repo @saramorillon

I believe you can work around this by setting "files.refactoring.autoSave": false

@jrieken The root cause is that autosave is being triggered during the code action’s save participant. I’ll look into suppressing this for code actions when saving

After I turned off ‘source.organizeImports’ it was fine

Perhaps this issue might have something to do with the recent changes here: #164035 ?

Same here with the vshaxe extension. I only had source.organizeImports in my codeActionsOnSave.

This regressed with https://github.com/microsoft/vscode/commit/dc04246b0ae4e05fe9a429915de75a9880e5db7b - honouring the autoSave-flag even for single file refactorings

@Zertz In my case, I have (or had before removing "source.organizeImports"):

"editor.codeActionsOnSave": {
  "source.organizeImports": true,
  "source.sortImports": true,
  "source.fixAll.markdownlint": true,
  "source.fixAll": true
}

Can confirm that this is an issue for us, also since updating to the latest VS Code version and no other changes. We also have the following settings.json, and run Prettier as part of ESLint’s fixAll rule.

  "editor.codeActionsOnSave": [
    "source.organizeImports",
    "source.fixAll.eslint"
  ],

I think that’s because the “fixAll” command also sorts/organises the imports.

That is the case in our setup, and is the expected behavior - however this bug appears even if fixAll doesn’t reorder the imports. The previous behavior was:

• organizeImports reorders the imports, but this may not match the code style enforced by Prettier.
• fixAll runs Prettier, which changes the code style: in our case, adding trailing commas to all multi-line imports.

This is the behavior mentioned in #98123. I consider this to be normal/expected (organizeImports probably shouldn’t reformat code, only reorder the imports).

However as explained by @TriStarGod this now occurs in a cycle: it seems like organizeImports is executed again after fixAll writes the fixed changes to the file, which then breaks the ESLint rule again.

This is the new behavior in action:

https://user-images.githubusercontent.com/38614/200349370-7eded26f-ee00-456b-b10d-8d824ef65f78.mov

I am still experiencing this problem for python files. What is the resolution?

Version: 1.73.0 Commit: 8fa188b2b301d36553cbc9ce1b0a146ccb93351f Date: 2022-11-01T15:38:50.881Z Electron: 19.0.17 Chromium: 102.0.5005.167 Node.js: 16.14.2 V8: 10.2.154.15-electron.0 OS: Darwin x64 21.6.0 Sandboxed: No

For me it’s still glitching with this config:

"editor.codeActionsOnSave": ["source.fixAll.format", "source.fixAll.eslint"]
"editor.defaultFormatter": "esbenp.prettier-vscode"

I had to downgrade to make it work again.

Same issue here, infinite organize import loop with flickering of import statements. I downgraded to version 1.72.2 for now. Hopefully this can be fixed.

No, it doesn’t, but it still seems like a regression in VSCode 🤔 I’m using eslint like this person, i.e. also with "editor.codeActionsOnSave": ["source.organizeImports", "source.fixAll.eslint"],. vscode-eslint hasn’t updated since July

In my case if I have an import statement like

import {
    makeStoreClosureEventId,
    parseStoreClosureEventId,
    StoreClosureEventIdType,
    validateStoreClosureEventId,
} from '@root/gql/types/StoreClosureEvent'

the organize imports step will remove the trailing comma and then eslint fixAll adds it back again. But instead of doing that just once, it now happens in a continuous loop

Same for me, also using Vue (Volar) extension. Disabling organizeImports works as a temporary fix.